Closed Bug 1653190 Opened 4 years ago Closed 4 years ago

format of firefox SHA512SUMS changed between betas 78 and 79

Categories

(Release Engineering :: General, defect)

defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox78 unaffected, firefox79+ fixed, firefox80+ fixed)

RESOLVED FIXED
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 + fixed
firefox80 + fixed

People

(Reporter: douglas.wilson, Assigned: rail)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

See https://github.com/mozilla/nixpkgs-mozilla/issues/231

I tried to install https://ftp.mozilla.org/pub/firefox/releases/79.0b8/ via the nixpkgs overlay https://github.com/mozilla/nixpkgs-mozilla

Actual results:

The overlay failed to parse the SHA256SUMS file. This is because the serialisation format has changed, see:
https://ftp.mozilla.org/pub/firefox/releases/78.0b9/SHA256SUMS
https://ftp.mozilla.org/pub/firefox/releases/79.0b1/SHA256SUMS

Expected results:

The serialisation format should not have changed

Seems like a Python 3 issue. The hash is now saved as b'1038bc291f2aa...', note the extra b and single quotes.

Component: Untriaged → General
Product: Firefox → Release Engineering
QA Contact: catlee
Version: 79 Branch → unspecified

A quick Google search leads me to believe that we just need to .decode() the hash in whatever Python script is being run to generate these checksum files. Unfortunately, it's not obvious to me where this script resides, so I cannot attempt to fix this myself.

$ python3
Python 3.8.3 (default, May 13 2020, 19:59:26)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> test=b'test'
>>> print(test)
b'test'
>>> print(test.decode())
test
>>>
Assignee: nobody → rail
Attachment #9165504 - Attachment is obsolete: true
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c1644949f8b
format of firefox SHA512SUMS changed between betas 78 and 79 r=Callek
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9165508 [details]
Bug 1653190 - format of firefox SHA512SUMS changed between betas 78 and 79 r=Callek

Beta/Release Uplift Approval Request

  • User impact if declined: End users are not affected by this
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change only affects release automation
  • String changes made/needed:
Attachment #9165508 - Flags: approval-mozilla-release?
Attachment #9165508 - Flags: approval-mozilla-beta?

Comment on attachment 9165508 [details]
Bug 1653190 - format of firefox SHA512SUMS changed between betas 78 and 79 r=Callek

Approved for whatever release comes off mozilla-release next (more likely a dot release than an RC respin). Clearing the Beta request because it's closed until merge day.

Attachment #9165508 - Flags: approval-mozilla-release?
Attachment #9165508 - Flags: approval-mozilla-release+
Attachment #9165508 - Flags: approval-mozilla-beta?

We switched to using python 3 to run generate-checksums, this caused the
checksum files to have an extra b'' in them. The original fix caused the
generation of merkletree to fail. This moves the code that encodes the hash
closer to where it is output.

Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/3894c97b6b94
Fix handling of checksum format in python 2 vs 3; r=mtabara
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: