1653265 - Sometimes the Picture-in-Picture toggle doesn't appear on Netflix videos

Status: RESOLVED DUPLICATE of bug 1605527

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

We've gotten a few reports on this on Twitter, and a few of us on the team have also observed this. We should figure out what's happening here.

Comment 1

[Mike Taylor [:miketaylr]]

If it's somehow possible that the PiP intervention for Netflix isn't working as expected, we can remove it:

https://searchfox.org/mozilla-central/source/browser/extensions/webcompat/data/picture_in_picture_overrides.js#31-32

It's seems less annoying to have a PiP toggle for a preview than to not have a PiP toggle for an actual video.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I finally had some time to look at this. This is indeed caused by the policy - we have a bug in our policy code that doesn't properly handle pages transitioning via the history API, so the policy is being transferred to the watch page.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

This should be fixed in Nightly now that bug 1605527 is fixed, but it'd be great is someone could verify it.