1653291 - Make "locales" and "options" arguments and the "type" property mandatory for Intl.DisplayNames

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, task, P2)

Description

[André Bargull [:anba]]

Make "locales" and "options" arguments and the "type" property mandatory for Intl.DisplayNames per the latest spec proposal changes. Also canonicalise the input arguments to the of() method.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1653291 - Part 1: Canonicalise input arguments to Intl.DisplayNames.p.of(). r=jwalden!

Moves the fallback handling from JS into C++ code, because the language, script,
and region tags were already canonicalised in C++, so handling the fallback path
in C++ altogether avoids repeated canonicalisation.

Drive-by:
Change Intl_DisplayNames_of to call ToString(code) before getDisplayNamesInternals()
following comments from a previous review.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1653291 - Part 2: Canonicalise "month" for Intl.DisplayNames. r=jwalden!

"month" is the only date-time type which may return an empty string (only for
Undecimber, though). Handle this case and also assert all other date-time types
always return a non-empty result.

Depends on D83944

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1653291 - Part 3: Zero initialise the script and region char arrays. r=jwalden!

Zero initialisation is cheap for this case (two mov for script and a single
mov for region types).

Depends on D83945

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1653291 - Part 4: Require 'locales' and 'options' arguments. r=jwalden!

Drive-by change:
Enable now passing test262 tests which weren't updated in the last test262 update.

Depends on D83946

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29b831c685f0
Part 1: Canonicalise input arguments to Intl.DisplayNames.p.of(). r=jwalden
https://hg.mozilla.org/integration/autoland/rev/c57a391c7063
Part 2: Canonicalise "month" for Intl.DisplayNames. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/0f66e6b2e06c
Part 3: Zero initialise the script and region char arrays. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/5c653e761010
Part 4: Require 'locales' and 'options' arguments. r=jwalden

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/29b831c685f0
https://hg.mozilla.org/mozilla-central/rev/c57a391c7063
https://hg.mozilla.org/mozilla-central/rev/0f66e6b2e06c
https://hg.mozilla.org/mozilla-central/rev/5c653e761010