Enigmail determineSendFlags() fires too often at every mouse interaction
Categories
(MailNews Core :: Security: OpenPGP, defect)
Tracking
(thunderbird_esr78 fixed, thunderbird79 fixed)
People
(Reporter: aleca, Assigned: KaiE)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Review |
The Enigmail integration added the determineSendFlags()
method which checks if the encryption is possible for every written recipient.
https://searchfox.org/comm-central/rev/337b77d55861522d05198bf971b042e8ed129a04/mail/extensions/openpgp/content/ui/enigmailMsgComposeOverlay.js#1396
This method gets fired at every mouse click, blur, or focus on any addressing field, even the subject line, going through all the available pills, and constantly triggering the Recipients2CompFields()
method.
This was probably necessary with the old implementation, but with the new pills feature, this check should only happen when a pill is created, and it should only check for the newly added address, without triggering the Recipients2CompFields()
method, since that is already handled by the pill creation itself.
Assignee | ||
Comment 1•4 years ago
|
||
yes we should remove that. We currently don't have UI to continuously show the "can encrypt" state.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
The attached patch removes all event based calls to that function, and that means we can remove the handlers, too.
Only when sending an encrypted message we call the function.
This should be OK for now. Once we need this information more often, let's invent something new (and keep this removal patch in mind for future inspiration).
Comment 4•4 years ago
|
||
Just to clarify the purpose of these event handlers: they where implemented in order to determine the send flags while the user adds or deletes recipients, i.e. to determine dynamically, while typing, if the message will be encrypted or not.
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/e3f2844a24eb
Only call OpenPGP composer determineSendFlags when necessary. r=PatrickBrunschwig
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9164096 [details]
Bug 1653311 - Only call OpenPGP composer determineSendFlags when necessary. r=PatrickBrunschwig
[Approval Request Comment]
Regression caused by (bug #): OpenPGP code
User impact if declined: slower UI
Testing completed (on c-c, etc.): yes manually, composer still working
Risk to taking this patch (and alternatives if risky): Minimal, strictly limited to experimental OpenPGP code
Comment 7•4 years ago
|
||
Comment on attachment 9164096 [details]
Bug 1653311 - Only call OpenPGP composer determineSendFlags when necessary. r=PatrickBrunschwig
Approved for esr78 and beta - please land
Assignee | ||
Comment 8•4 years ago
|
||
https://hg.mozilla.org/releases/comm-esr78/rev/4660c151da3948bcde9f402523d22a92e1487196
https://hg.mozilla.org/releases/comm-beta/rev/64bb0858073a6d2d01395df6a2b4cddf09360e77
Assignee | ||
Updated•4 years ago
|
Description
•