chatzilla should give better error messages when /join fails

RESOLVED FIXED

Status

Other Applications
ChatZilla
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: Samuel Sieb, Assigned: James Ross)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: cz-patch)

Attachments

(2 attachments)

(Reporter)

Description

15 years ago
There are specific error codes for when a join fails for different reasons.
For example: 475 ERR_BADCHANNELKEY  "<channel> :Cannot join channel (+k)"
Instead of just displaying the message, chatzilla should give a clearer reason
for the error, like "You need a key", or "You entered the wrong key".
(Assignee)

Updated

14 years ago
Assignee: rginda → silver
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

14 years ago
Created attachment 141194 [details] [diff] [review]
Display better messages for join errors

I thought it would be nice to make replacing random error numerics easy, so
this code just tries to find a string, and if it fails it falls back to the old
code. Patch includes the four join errors that I could find.
(Assignee)

Updated

14 years ago
Whiteboard: cz-patch
(Assignee)

Updated

14 years ago
Attachment #141194 - Flags: review?(samuel)
(Reporter)

Updated

14 years ago
Attachment #141194 - Flags: review?(samuel) → review+
(Assignee)

Comment 2

14 years ago
Comment on attachment 141194 [details] [diff] [review]
Display better messages for join errors

Checked in.
(Assignee)

Updated

14 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 3

14 years ago
there's a couple of mistakes in one of the messages that got added here

"This channel has reached it's set capacity; you connot join it."

"it's" should be "its" and "connot" should be "cannot"
(Assignee)

Comment 4

14 years ago
Created attachment 144222 [details] [diff] [review]
Fixes errors in text
(Assignee)

Updated

14 years ago
Attachment #144222 - Flags: review?(samuel)
(Reporter)

Updated

14 years ago
Attachment #144222 - Flags: review?(samuel) → review+
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.