1653376 - DevTools highlighter doesn't work on the elements itself

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Richard Marti (:Paenglab)]

When opening the DevTools a iframe appears on the bottom of every inspected window.

This comes after Bug 1648161 and Bug 1650094.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1653376-devtools-highlighter-fix.patch

Geoff, you know XUL very good. That's why I'm asking you for review.
I removed the XUL namespace in content/messenger.css. This makes the needed rules for the highlighter (https://searchfox.org/comm-central/rev/c28e45bcb3b5e4f9be5c42ba9345790096047633/mail/base/content/messenger.css#226 and https://searchfox.org/comm-central/rev/c28e45bcb3b5e4f9be5c42ba9345790096047633/mail/base/content/messenger.css#232) work again.

Do you see something negative when I remove it?

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9164129 [details] [diff] [review]
1653376-devtools-highlighter-fix.patch

You probably could've just set the xhtml namespace on the devtools iframe, but I see no reason to keep the namespace restriction in this file.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d95bded5d953
Remove the XUL namespace in content/messenger.css to make the DevTools highlighter work again. r=darktrojan

Comment 4

[Geoff Lankow (:darktrojan)]

Thanks for figuring this out, Richard!