1653394 - Remove 600 character limit on localized updater strings

Status: RESOLVED FIXED

(Toolkit :: Application Update, task)

Description

[Robin Steuber (they/them) [:bytesized]]

The string we are talking about adding in Bug 1633899 has a length worrying close to the 600 character limit imposed here. Some translations will likely be longer than 600 characters.

I took a look at the implementation, and I think don't think it should be too hard to remove the limit.

Comment 1

[Rachel Tublitz [:rachel]]

I imagine that limit was added as a precaution of some sort? Do we know why?

Comment 2

[Robin Steuber (they/them) [:bytesized]]

It's not enforced arbitrarily, but it is the arbitrary size of the buffer we use to read the data. There should be no reason we can't use dynamically sized buffers to avoid the limit.

Comment 3

[Robin Steuber (they/them) [:bytesized]]

Attachment: Bug 1653394 - Dynamically allocate string buffers in ReadStrings() to remove the 600 character limit r=mhowell,Pike

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10f8b5190b60
Dynamically allocate string buffers in ReadStrings() to remove the 600 character limit r=mhowell,Pike

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/10f8b5190b60