1653486 - Replace all non-user-facing references to "master" password

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[Matthew N. [:MattN]]

The term "master" in software makes reference to the "Master/Slave" relationship. As one action to uproot this problematic terminology (see Meta bug), we should replace it. Bug 1644807 dealt with user-facing references while this bug will deal with the remaining non-user-facing references in code and code comments.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

After bug 1644807 landed, about:policies switched the "policy-MasterPassword" to "policy-PrimaryPassword" but "policy-DisableMasterPasswordCreation" is still shown despite a string "policy-DisablePrimaryPasswordCreation" getting added. Will it get used in this bug?

Comment 2

[Mike Kaply [:mkaply]]

We can't rename the policy "DisableMasterPasswordCreation" because we have to maintain support for that policy forever. We did update the policy to use the new string:

DisableMasterPasswordCreation If true, a Primary Password can’t be created.

And we are using that new string:

https://searchfox.org/mozilla-central/source/browser/components/enterprisepolicies/content/aboutPolicies.js#289

So as far as I'm concerned, this is a non issue. We can't rename the DisableMasterPasswordCreation policy.

Comment 3

[Sergey Galich [:serg]]

Attachment: WIP: Bug 1653486 - Replace all non-user-facing references to "master" password

Comment 4

[Sergey Galich [:serg]]

Attachment: Bug 1653486 - Replace all non-user-facing references to "master" password. r=dimi!,tgiles!

Comment 5

[Sergey Galich [:serg]]

Attachment: WIP: Bug 1653486 - P2. Replace all non-user-facing references to "master" password in logs and exception messages

Depends on D138078

Comment 6

[Sergey Galich [:serg]]

Attachment: Bug 1653486 - Replace all non-user-facing references to "master" password. r=dimi!,tgiles!

Comment 7

[Sergey Galich [:serg]]

Attachment: Bug 1653486 - Replace all non-user-facing references to "master" password. r=dimi!,tgiles!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b784d470808
Replace all non-user-facing references to "master" password. r=dimi,tgiles,preferences-reviewers

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2b784d470808

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/31618a42d34a
Replace Thunderbird non-user-facing references to "master" password. rs=bustage-fix DONTBUILD

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/835e6c7d6897
further fix Thunderbird non-user-facing references to "master" password. rs=bustage-fix