Closed Bug 1653489 Opened 5 years ago Closed 3 years ago

moz-phab doesn't clobber "Draft" state even after moz-phab submit again without "--wip"

Categories

(Conduit :: moz-phab, defect, P2)

Product:
Conduit
Component:
moz-phab
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: hiro, Assigned: grammar)

References

Details

(Keywords: conduit-triaged)

Botond told me that it was fixed in bug 1564166. But it happened again (bug 1638152 comment 11). And now I could re-confirm it still persists, I mean it happened now in bug 1652190.

Severity: -- → S1
Keywords: conduit-triaged
Priority: -- → P2

I seem to have encountered this bug. But the surprising part to me wasn't necessarily that the patches didn't go from the "Changes Planned" state to the "Request Review" state. I wasn't really sure what would happen. But then moz-phab specifically claimed that it was going to do this:

...
( New) 557610:efebf4cb2ffc Bug 353804 - Add UI tests for the multiple update downloads per session functionality r=mhowell!
( New) 557609:76a8704e7b7e Bug 353804 - Add tests of the AUS changes to allow multiple downloads per Firefox session r=mhowell!
( New) 557608:50ff85ab9b5e Bug 353804 - Fix a function that expects AUS.downloadUpdate to return a state r=mhowell!
( New) 557607:5829f7695d61 Bug 353804 - Fix test broken by enabling multiple update downloads per session r=mhowell!
( New) 557606:49b85ef4d224 Bug 353804 - Add telemetry for states introduced by allowing multiple updates per session r=mhowell!,chutten!
(D95821) 557605:3a8f701391a3 Bug 353804 - Add update swap handling to UpdateListener and AppUpdater r=mhowell!
!! "Changes Planned" status will change to "Request Review"
(D95820) 557604:a5c211aec0fb Bug 353804 - String changes needed for multiple updates per Firefox session r=mhowell!,flod!
!! "Changes Planned" status will change to "Request Review"
(D95819) 557603:b07bba47879f Bug 353804 - Enable downloading multiple updates per Firefox session r=mhowell!
!! "Changes Planned" status will change to "Request Review"
Checking commits.. -b07bba47879f is based off non-public commit ac0d703f3787
...

But then it didn't do what it claimed it would do. It just left the reviews in the "Changes Planned" state and I had to go change them manually.

I really don't think moz-phab should claim that it's going to do this, not do it, and then exit with no indication of an error.

Severity: S1 → --
Severity: -- → S3
Assignee: nobody → grobertson

attempted to reproduce this bug in a variety of ways and have been unable to, closing for now. if it re-occurs, feel free to re-open this bug!

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.