1653506 - Run WebExtensions tests with an IMAP server

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Most of the tests in mail/components/extensions only test against a local server. This bug is about making them also run with an IMAP server.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1653506 part 1 - Refactor WebExtensions tests to use a common utilities file

I've extracted commonly used functions to a separate file (utils.js) and included it in the test
extensions. I've avoided massive indentation change where possible by using a containing object.
I might tidy up the indentation in a future revision which can be marked as ignored by hg anno.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1653506 part 2 - Run WebExtensions XPCShell tests with an IMAP server

Created a duplicate test manifest which wraps the default createAccount function so that it
defaults to IMAP. There's also a bunch of utility functions for handling IMAP's asynchronicity and
a lot of tidying up.

There's a few things that just don't work on IMAP, which is the point of this bug, and will need to
be fixed in further patches.

Depends on D83910

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f5e11159eb2a
part 1 - Refactor WebExtensions tests to use a common utilities file r=mkmelin
https://hg.mozilla.org/comm-central/rev/5114b1ed26cd
part 2 - Run WebExtensions XPCShell tests with an IMAP server r=mkmelin

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9164278 [details]
Bug 1653506 part 1 - Refactor WebExtensions tests to use a common utilities file

[Approval Request Comment]
Bug 1617461 was approved for uplift for 78.3.2, and it has a dependency on the getUtilsJS() function that's created in this patch.
The change itself is only unittests, so the only risk is that the tests fail. The changes landed in Thunderbird 81, so they have been on beta for some time. Any problems we do run into on the release branch should have fixes readily available.

[Triage Comment]
Test-only changes approved. I expect more MailExtension API's to be added over the coming months and in the interest of developer sanity it makes sense to be able to run the same unittests that were developed and vetted on trunk and beta on the release branch.

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9164279 [details]
Bug 1653506 part 2 - Run WebExtensions XPCShell tests with an IMAP server

[Triage Comment]

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.3.2:
https://hg.mozilla.org/releases/comm-esr78/rev/aff8c053cd75f
https://hg.mozilla.org/releases/comm-esr78/rev/9cdfdbe7adfa

Backout 78.3.2:
https://hg.mozilla.org/releases/comm-esr78/rev/ab7d41cf420f

This bug is entangled with bugs 1617461, 16622015, and 1662018, and some more as yet unidentified. Holding for 78.4.0 as some contain MailExtenson API changes, which we should be avoiding in point releases.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1653506-pt2-esr.diff

ESR78 version of part 2.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/6725d4d6e9e6
https://hg.mozilla.org/releases/comm-esr78/rev/8ce738e24c92