Restrict about:logins OS-reauthentication feature to Thunderbird Daily
Categories
(Thunderbird :: Security, task, P1)
Tracking
(thunderbird_esr78+ fixed, thunderbird79 affected)
People
(Reporter: wsmwk, Assigned: mkmelin)
References
Details
Attachments
(1 file)
3.30 KB,
patch
|
Paenglab
:
review+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1641473 +++
(For Firefox the feature was disabled for 77 in bug 1636511.)
We shouldn't be shipping the OS login yet, as Firefox hasn't completed their work.
Thunderbird re-enable is bug 1653516
Assignee | ||
Comment 1•4 years ago
|
||
I think we only use it for when to change primary password (former master password). I don't see anything when opening the passwords dialog normally.
So just change https://searchfox.org/comm-central/source/mail/components/preferences/privacy.js#374 to "AppConstants.NIGHTLY_BUILD ||"?
Comment 2•4 years ago
|
||
It's also when you press "Show Passwords" in the password manager.
Assignee | ||
Comment 3•3 years ago
|
||
Comment 4•3 years ago
|
||
Comment on attachment 9187596 [details] [diff] [review]
bug1653517_os_reauth_disable.patch
Thanks.
Assignee | ||
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c128cb4ce9be
disable OS reauth for Tunderbird non-nightly builds. r=Paenglab
Assignee | ||
Comment 6•3 years ago
|
||
Comment on attachment 9187596 [details] [diff] [review]
bug1653517_os_reauth_disable.patch
[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: possible confusion, unpolished UI requesting OS auth when viewing passwords
Testing completed (on c-c, etc.): been on beta
Risk to taking this patch (and alternatives if risky): no risk
Reporter | ||
Comment 7•3 years ago
|
||
Comment on attachment 9187596 [details] [diff] [review]
bug1653517_os_reauth_disable.patch
[Triage Comment]
Approved for esr78
Comment 8•3 years ago
|
||
bugherder uplift |
Thunderbird 78.5.1:
https://hg.mozilla.org/releases/comm-esr78/rev/a136e1894f41
Description
•