Closed Bug 1653543 Opened 4 years ago Closed 2 years ago

With socket process on, `browser.dns` API still resolves hosts names with SOCKS proxy doing DNS

Categories

(Core :: Networking, defect, P3)

defect

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: mayhemer, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1649813#c4

In bug 1618271 we disabled DNS resolution when SOCKS is configured, enabled and set to do DNS. We simply check preferences at nsDNSService::DNSForbiddenByActiveProxy and bypass.

But, when socket process is enabled, this is broken again.

Flags: needinfo?(kershaw)
Flags: needinfo?(kershaw)
Priority: -- → P3
Whiteboard: [necko-triaged]
Assignee: nobody → kershaw
Status: NEW → ASSIGNED
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f16830944997
When socket process is used, don't leak host name with SOCKS proxy, r=necko-reviewers,valentin

Backed out changeset f16830944997 (Bug 1653543) for causing build bustages on DNSServiceBase.cpp.
Backout link
Push with failures
Failure Log

Flags: needinfo?(kershaw)
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0805b2cdc841
When socket process is used, don't leak host name with SOCKS proxy, r=necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: