1653700 - Can't zoom Bing Maps using trackpad scroll gesture with apz.windows.use_direct_manipulation = true

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Chris Peterson [:cpeterson]]

Steps to reproduce

1. Load https://www.bing.com/maps/.
2. Try to zoom the map in or out using trackpad scroll gesture.

Expected result

The map should zoom in and out.

Actual result

The map doesn't zoom with the trackpad scroll gesture, but I can zoom the map using a pinch gesture on my laptop's touchscreen or clicking the maps' +/- buttons.

I'm using Windows 10. I haven't tested any other platform. Note that I can't reproduce this problem in a clean profile, only my regular profile. To bisect this problem, I had to clone my regular profile in mozregression.

I don't know if this Bing Maps problem is related, but I've had intermittent problems for months where Nightly would stop responding to my trackpad scroll gestures entirely, in all tabs. I wouldn't be able to scroll web pages using my trackpad. I would have to click and drag the scrollbar or navigate using cursor keys. I didn't have good STR and the problem would usually go away after a minute or so.

Comment 1

[Chris Peterson [:cpeterson]]

@ tnikkel, I think this bug is a regression from your changes for direct manipulation bug 1630912 in Firefox 78. Looks like I had manually set the apz.windows.use_direct_manipulation pref = true a few months ago. I can make the zoom problem go away by toggling apz.windows.use_direct_manipulation in a clean profile.

I bisected this bug to the following pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=49df0c8504b8521913eca4fc6163017e0133e6bb&tochange=804dc7924101573ca673d3eb16ca28bd29235b96

Comment 2

[Timothy Nikkel (:tnikkel)]

Thanks for the report and for bisecting and testing with the flipped pref!

Comment 3

[Timothy Nikkel (:tnikkel)]

Similar observations as bug 1644952 comment 2. Looks like dmanip scroll gestures don't send DOMMouseScroll events.

Comment 4

[Timothy Nikkel (:tnikkel)]

The macOS widget code puts something in the PanGestureInput::mLineOrPageDeltaY here

https://searchfox.org/mozilla-central/rev/d6d8fcc22c3820f2ae08229e0d37be19fba74db9/widget/cocoa/nsChildView.mm#3491

but we have nothing for d manip doing the same. So in EventStateManager::DispatchLegacyMouseScrollEvents the scrollDeltaY is always 0 and we never dispatch a DOMMouseScroll event.

Comment 6

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1653700. Populate PanGestureInput::mLineOrPageDeltaX/Y when the events are produced from direct manipulation. r=kats

This basically just copies what the macOS widget code does starting here

https://searchfox.org/mozilla-central/rev/d6d8fcc22c3820f2ae08229e0d37be19fba74db9/widget/cocoa/nsChildView.mm#3491

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd88950d6cec
Populate PanGestureInput::mLineOrPageDeltaX/Y when the events are produced from direct manipulation. r=kats

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bd88950d6cec