1653763 - OpenPGP recipient key matching fails for keys that contain only email address, but no name

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[lencalot]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1. Installation of Thunderbird 78.0b4.
2. Add Mail Account 1 & 2
3. Create a new secret GPG key with Thunderbird 78.0b4 for Mail Account 1
4. Import secret key for Mail Account 2, that was created with GnuGPG (RSA 4096) and some public keys for other Recipients
5. Set trust level for these keys to "Yes, I have verified in person..."
6. Try to send a mail with new secret key as sender [78.0b4 & 79.0b1]
7. Try to send a mail with the older, imported key as sender [78.0b4 & 79.0b1]
8. Installation on another computer and try again -> same behaviour.

Actual results:

Sending a mail from Mail Account 2 with the imported key (signer) to Mail Account 1 and using the new created secret key (encryption) works fine.

Sending a mail from Mail Account 1 with the new key (signer) to Mail Account 2 and using the imported key (encryption) doesn't work.

Sending a mail from Mail Account 1 to any other recipient with imported gpg key doesn't work.

Got a error message, but without any clue what went wron... "Sending of the message failed".

Expected results:

Expected result should be that the mail can be send encrypted.

Comment 1

[Kai Engert (:KaiE:)]

After importing a secret key, you must confirm that it is your personal key. Use menu tools / openpgp key management, open your key, and confirm "yes, treat this key as a personal key".

Importing using the final release will ask that question on import.

Does that help?

Comment 2

[lencalot]

No, that does'nt help. I have set them as personal key after import.

Comment 3

[Kai Engert (:KaiE:)]

Do you still have this issue with 78.0.1 ?

I currently don't have an idea what's going wrong.

Comment 4

[lencalot]

I have create a couple of new keys with Kleopatra and import to Thunderbird for testing:

• RSA 2048: it works fine
• RSA 3072: it works fine
• RSA 4096: it doesn't works

I have create a key directly in Thunderbird for doublechecking:

• RSA 4096: it works fine

I have currently version 79.0b2 (Win 10, 64-Bit).

Comment 5

[lencalot]

And another test, two keys created with Kleopatra and imported to Thunderbird:

• RSA 4096 with name and mail address: it works
• RSA 4096 without name, with mail address: it doesn't works

Comment 6

[lencalot]

(In reply to Kai Engert (:KaiE:) from comment #3)

Do you still have this issue with 78.0.1 ?

I currently don't have an idea what's going wrong.

Tested with 80.0b1 again. Still the same issue.

For testing, I have add a name to my keys with Kleopatra and then imported it again to Thunderburd. Then it's works fine with the same Key. So I have a workaround for the moment, but It would be nice to use keys without name assigned to send encrypted mails.

To summarize: The issue is that keys without names don't seem to work.

Comment 7

[Kai Engert (:KaiE:)]

Thanks, the missing name is indeed the cause, we have an incorrect check.

Comment 8

[Kai Engert (:KaiE:)]

Attachment: Bug 1653763 - OpenPGP recipient key matching fails for keys that contain only email address, but no name. r=PatrickBrunschwig

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c3c67a991a8
OpenPGP recipient key matching fails for keys that contain only email address, but no name. r=PatrickBrunschwig DONTBUILD

Comment 10

[Magnus Melin [:mkmelin]]

Seems there's some linting failures from this. Can you take care?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d954ce81278c
Follow-up to fix line. rs=lint

Comment 12

[Kai Engert (:KaiE:)]

phab updated to include lint fix

Comment 13

[Kai Engert (:KaiE:)]

Comment on attachment 9168180 [details]
Bug 1653763 - OpenPGP recipient key matching fails for keys that contain only email address, but no name. r=PatrickBrunschwig

OpenPGP correctness fix. No risk.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9168180 [details]
Bug 1653763 - OpenPGP recipient key matching fails for keys that contain only email address, but no name. r=PatrickBrunschwig

[Triage Comment]
Approved for beta

Comment 15

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-beta/rev/a664e0d050f964c0c2f77a04dcfa19b754416d42

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9168180 [details]
Bug 1653763 - OpenPGP recipient key matching fails for keys that contain only email address, but no name. r=PatrickBrunschwig

[Triage Comment]
Approved for esr78

Comment 17

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/b59b5694262d43d3f8364ff5455144fbb093284f