1653798 - Add Primary Password SUMO link and text about the name change

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Matthew N. [:MattN]]

1. SUMO Learn More link redirecting to https://support.mozilla.org/kb/use-master-password-protect-stored-logins
   • Needinfo to Joni for the in-product link
   • QA note: the Learn More link is intentionally moved to beside the checkbox and isn't specific to the renaming
2. transitional text for Fx80 (attachment 9163538 [details])

Comment 1

[Joni Chan]

Here's the link for #1: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/primary-password-stored-logins

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1653798 - Add Primary Password SUMO link and text about the name change. r=#preferences-reviewers!

.hidden = true is used when this name didn't change for a locale. Setting the string to empty is treated as if the string wasn't found and that causes about:preferences not to load the whole Privacy section so that's why this approach was used instead.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9520e660ca99
Add Primary Password SUMO link and text about the name change. r=preferences-reviewers,fluent-reviewers,flod,ntim

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9520e660ca99

Comment 5

[Matthew N. [:MattN]]

Reminder to SUMO to update the page from comment 1 to rename to Primary Password with a banner explaining the transition.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Matthew N. [:MattN] from comment #0)

2. transitional text for Fx80 (attachment 9163538 [details])

Has anyone considered ESR? The current (78) still has Master Password, the next one won't have it, but it also won't have the disclaimer/note.

Comment 7

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Nightly 80.0a1 (2020-07-24) (64-bit) on Windows 10, MacOS 10.13 and Ubuntu 16.04.
Also verified RTL build (arabic) for text and sumo link position. FYI, Localization of the strings are not done yet.