1653846 - Sync icon spinning all the time

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mic Sparrow]

Attachment: 2.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Open latest Firefox Nightly.
After a few seconds the Sync icon starts spinning (as opened from the Firefox account icon).

Actual results:

Sync icon spins for a very long time (and it shouldn't).
Clicking for example 'tabs from other devices' and going back to the Firefox account tab fixes this issue.

Expected results:

Sync icon should revert back to the grayed out icon after a few second.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

We're sorry to hear you are having this problem, but thanks very much for taking the time to make this report. We aren't sure what is causing this issue, but Sync does keep some logs which may help us find the problem. Instructions for how to locate and attach the logs can be found at https://wiki.mozilla.org/CloudServices/Sync/File_a_desktop_bug - and in particular, follow the instructions for enabling "success" logs, then reproduce your issue (eg, perform a new sync), and attach any new logs which then appear.

Comment 3

[Mic Sparrow]

In the attachment you can find 2 logs. One log is showing some erroors. It is from yesterday. All other logs are so-called 'success-logs'. The last one of them is also attached (as shown in the picture).

Comment 4

[Mic Sparrow]

Attachment: SYNCLOGS.png

Comment 5

[Mic Sparrow]

Attachment: error-sync-1595152083332.txt

Comment 6

[Mic Sparrow]

Attachment: success-sync-1595258139300.txt

Comment 8

[Mark Hammond [:markh] [:mhammond]]

I believe this was caused by bug 1648637. In particular, https://searchfox.org/mozilla-central/source/browser/base/content/browser-sync.js#703 isn't working as expected - syncNow.getAttribute("syncstatus") is returning an empty string instead of active (although it's possible the actual bug is where the value is set in onActivityStart() - that unconditionally uses document.querySelectorAll(".syncNowBtn") and doesn't seem to use viewCacheTemplate.content at all, but without digging further into that patch I can't tell what's correct and what's not.

Comment 9

[Emma Malysz]

Attachment: Bug 1653846, ensure sync now buttons are all given correct attributes to correctly perform sync animation.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb84106a671c
ensure sync now buttons are all given correct attributes to correctly perform sync animation. r=Gijs

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cb84106a671c