Closed Bug 1653895 Opened 4 years ago Closed 4 years ago

Rename ScopeCreationData::create to different name for each input

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

ScopeCreationData::create has 7 overloads for each scope.

while developing, if I pass wrong parameter, the error message suggests all those overloads, with hint for each case,
and it's hard to figure out which one is right.

IMO, it's better renaming them into different name for each scope kind.

Severity: -- → N/A
Priority: -- → P3
Depends on: 1653248
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/a70fd734f621
Rename ScopeStencil::create for each case. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Blocks: stencil-backlog
No longer blocks: stencil
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: