1653922 - Crash in [@ nsFocusManager::WindowHidden]

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Gabriele Svelto [:gsvelto]]

This bug is for crash report bp-7b504477-ffd8-4348-a664-5fe780200719.

Top 10 frames of crashing thread:

0 XUL nsFocusManager::WindowHidden dom/base/nsFocusManager.cpp:1034
1 XUL <name omitted> dom/base/nsGlobalWindowInner.cpp:4193
2 XUL nsDocumentViewer::PageHide layout/base/nsDocumentViewer.cpp:1378
3 XUL nsDocShell::FirePageHideNotificationInternal docshell/base/nsDocShell.cpp:1004
4 XUL nsDocShell::CreateContentViewer docshell/base/nsDocShell.cpp:7412
5 XUL nsDSURIContentListener::DoContent docshell/base/nsDSURIContentListener.cpp:182
6 XUL nsDocumentOpenInfo::TryContentListener uriloader/base/nsURILoader.cpp:597
7 XUL nsDocumentOpenInfo::DispatchContent uriloader/base/nsURILoader.cpp:276
8 XUL nsDocumentOpenInfo::OnStartRequest uriloader/base/nsURILoader.cpp:154
9 XUL mozilla::net::HttpChannelChild::DoOnStartRequest netwerk/protocol/http/HttpChannelChild.cpp:700

This is clearly a regression, it started with buildid 20200717093907. There are older non-nightly crashes but they're unrelated.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

May related to https://bugzilla.mozilla.org/show_bug.cgi?id=1646542?

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1653922: Add missing null check. r=nika

IsSameOrAncestor used to accidentally do this when it walked the parent chain
using docshells rather than BrowsingContexts.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74f5bb506fa7
Add missing null check. r=nika

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/74f5bb506fa7