Closed Bug 1653958 Opened 11 months ago Closed 10 months ago

Search result not correctly aligned for Zoom section when searching for numbers in about:preferences

Categories

(Firefox :: Preferences, defect, P3)

Product:
Firefox
Component:
Preferences
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- verified
firefox81 --- verified

People

(Reporter: atrif, Assigned: itiel_yn8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

screenshot
38.30 KB, image/png
Details
Bug 1653958 - Fix the search tooltip position on the "Default zoom" menulist. r?#preferences-reviewers
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review
Attached image screenshot —

Affected versions

  • 80.0a1 (20200719185002)
  • 79.0b9 (20200717001501)
  • 78.0.2 (20200708170202)

Affected platforms

  • Windows 10x64
  • macOs 10.12
  • Ubuntu 18.04

Steps to reproduce

  1. Open Firefox and go to about:preferences page.
  2. Type a random number in Find in Options (e.g 30).

Expected result

  • All results are correctly displayed.

Actual result

  • Zoom result is not correctly aligned.

Regression range

Notes

  • Attached a screenshot.
    Severity S4
Has Regression Range: --- → yes
Has STR: --- → yes
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Attachment #9166235 - Attachment description: Bug 1653958 - Fix the search tooltip position on the default zoom menulist r?#preferences-reviewers → Bug 1653958 - Fix the search tooltip position on the "Default zoom" menulist. r?#preferences-reviewers
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7e387faa6a4f
Fix the search tooltip position on the "Default zoom" menulist. r=preferences-reviewers,ntim

https://hg.mozilla.org/mozilla-central/rev/7e387faa6a4f

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Verified using Firefox 81.0a1 (20200729213824) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox81: fixed → verified

Did you want to nominate this for Beta uplift for Fx80?

Flags: needinfo?(itiel_yn8)

Comment on attachment 9166235 [details]
Bug 1653958 - Fix the search tooltip position on the "Default zoom" menulist. r?#preferences-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: Searching for numbers in about:preferences will display the search tooltip in the wrong position on the Default Zoom section.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This removes a 1 line code which was probably copy-pasted from other sections in about:preferences where flex was needed.
  • String changes made/needed: None
Flags: needinfo?(itiel_yn8)
Attachment #9166235 - Flags: approval-mozilla-beta?

Comment on attachment 9166235 [details]
Bug 1653958 - Fix the search tooltip position on the "Default zoom" menulist. r?#preferences-reviewers

approved for 80.0b6

Attachment #9166235 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Verified fixed with Firefox 80.0b6(20200807195315) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.

status-firefox80: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.