1653976 - perma toolkit/components/search/tests/xpcshell/test_reload_engines.js | test_config_updated_engine_changes - [test_config_updated_engine_changes : 242] Should have removed the expected engine - ["engine-resourceicon","engine-same-name"] ...

Status: RESOLVED FIXED

(Thunderbird :: Search, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=310264923&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NLDmyeqNSTu8Cg-w8hN7MA/runs/0/artifacts/public/logs/live_backing.log

---

Look to have started with https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=f94d1b1bef0a844f6bcf0719ae2e0466968cf660 (probably an m-c change)

Comment 1

[Magnus Melin [:mkmelin]]

From bug 1610293.

Don't know why the engine-rel-searchform-purpose isn't included in the removed ones. I note that it doesn't have a second appliesTo item like the other ones that it works for. Why this specific case doesn't work for Thunderbird is also a mystery. Perhaps some pref that's still missing or needs to be set. Or a pref being set too late?

Comment 2

[Mark Banner (:standard8)]

This does look like the modernConfig pref is not set for Thunderbird for this test, but toolkit/components/search/tests/xpcshell/head_modernconfig.js should be doing that.

Could someone verify that in SearchService's init() function the modernConfig is set to true for this test?

Comment 3

[Magnus Melin [:mkmelin]]

browser.search.modernConfig is true for SearchService.init(), so it must be something else.

Comment 4

[Mark Banner (:standard8)]

I just tested this and the failures here have revealed a timing issue - see bug 1654377 for the details. I'll fix it there - I filed a separate bug so you could still track the test failures here, and I could get a clear description written.

Comment 5

[Magnus Melin [:mkmelin]]

Fixed by bug 1654377, thx Mark!

Comment 6

[Mark Banner (:standard8)]

No problem, this found a potential bug so I'm glad we caught it.

Comment 7

[Intermittent Failures Robot]

48 failures in 4310 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #23 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 48

Platform breakdown:

• windows7-32-shippable: 5
• linux64-shippable: 8
• macosx1014-64-shippable: 6
• windows10-64-shippable: 4
• windows10-64: 5
• macosx1014-64: 8
• linux64: 8
• windows7-32: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1653976&startday=2020-07-20&endday=2020-07-26&tree=all