Closed
Bug 1654040
Opened 4 years ago
Closed 4 years ago
Add some more information to the video frame profiler markers
Categories
(Core :: Graphics, task)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla80
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The youtube-playback raptor test seems to run out of frames in the compositor on macOS - the decoder isn't sending enough frames (or isn't sending the frames frequently enough) so the compositor has to pick old frames.
To confirm this, we can add a bit more information to the profiler markers.
Here's a profile that was collected by the raptor T-prof(ytp) job, with the new marker information: https://share.firefox.dev/3jm1Hpt
And indeed, all of the "Video frames dropped" markers are preceded by "0 remaining images" markers.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D84212
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/73e95de6b6fc Add the number of remaining images in mImages to the UpdateCompositedFrame compositor marker. r=nical https://hg.mozilla.org/integration/autoland/rev/dc840b9b8b1b Add an ImageComposite::SetImages marker that records the supplied frameIDs. r=nical
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/73e95de6b6fc
https://hg.mozilla.org/mozilla-central/rev/dc840b9b8b1b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in
before you can comment on or make changes to this bug.
Description
•