Closed Bug 1654054 Opened 4 years ago Closed 2 years ago

Port videocontrols to Fluent

Categories

(Toolkit :: Video/Audio Controls, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: mconley, Assigned: niklas)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files, 1 obsolete file)

The localization team requested as part of the deal for allowing new DTDs into the tree for bug 1653663, that we commit to porting all of videocontrols.js to Fluent for an upcoming release.

This will require platform support to allow DOMLocalization into the UAWidget scope (see bug 1504363).

As part of my work on bug 1496851, videocontrols.js can now use (and does use) Fluent. I only used Fluent for new strings, though. Existing DTD strings still need to be ported.

Depends on: 1496851
Blocks: 1662870
No longer blocks: 1651414
Blocks: 1685549
No longer blocks: 1662870
Assignee: nobody → chenggu3
Status: NEW → ASSIGNED
Attachment #9204883 - Attachment description: Bug 1654054 - Add migration recipe for videocontrols. r?mtigley,mhowell" → Bug 1654054 - Add migration recipe for videocontrols. r?mtigley,mhowell
Attachment #9204883 - Attachment description: Bug 1654054 - Add migration recipe for videocontrols. r?mtigley,mhowell → Bug 1654054 - Add migration recipe for videocontrols. r?mtigley,mhowell"

Hi Guanlin! Just checking to see if you're still able to work on this?

Flags: needinfo?(chenggu3)
Flags: needinfo?(chenggu3)
Flags: needinfo?(mtigley)
Attachment #9200127 - Attachment description: Bug 1654054 - Port videocontrols to Fluent. r=mtigley,mhowell → WIP: Bug 1654054 - Port videocontrols to Fluent. r=mtigley,mhowell
Attachment #9204883 - Attachment description: Bug 1654054 - Add migration recipe for videocontrols. r?mtigley,mhowell" → WIP: Bug 1654054 - Add migration recipe for videocontrols. r?mtigley,mhowell"
No longer blocks: 1579477
Flags: needinfo?(mtigley)
Flags: needinfo?(mtigley)

Removing needinfo on this since I haven't had time to investigate test failures recently.

Flags: needinfo?(mtigley)
See Also: → 1735568
Blocks: 1742457

The bug assignee didn't login in Bugzilla in the last 7 months.
:jaws, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: chenggu3 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jaws)

Niklas and Katherine, could either of you like to pick this up?

Flags: needinfo?(nbaumgardner)
Flags: needinfo?(kpatenio)
Flags: needinfo?(jaws)

I can take this

Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Flags: needinfo?(nbaumgardner)
Flags: needinfo?(kpatenio)

I actually had started tinkering with this on the side. It was the subject of my last Joy of Coding episode if you want to see where I got with it! (not tooo too far): https://www.youtube.com/watch?v=RJvfK84OjQ4

There are some gotchas here with test failures in toolkit/content/tests/widgets. I traced at least part of it down to the fact that Fluent replaces nodes that have data-l10n-name when doing translation as part of santization: https://searchfox.org/mozilla-central/rev/9d66919569655a8fae9b431550241c058fa85b8a/dom/l10n/L10nOverlays.cpp#359

this means that if the translation has not completed by the time the durationSpan control is defined, it'll be pointed at the wrong DOM node (one that has been replaced, and is no longer connected to the document).

I'll post what I have so far in case you want to start with it (no obligation).

Attachment #9204883 - Attachment description: WIP: Bug 1654054 - Add migration recipe for videocontrols. r?mtigley,mhowell" → WIP: Bug 1654054 - Port videocontrols to Fluent. r=mtigley!,mhowell!
Attached file WIP: Bug 1654054 - Debugging (obsolete) —

Depends on D139742

The main porting patch might be useful at least to save you some rebasing effort. The "debugging" patch is various semi-successful half-baked stabs by myself to fix the test failures.

Thanks Mike!

Attachment #9265552 - Attachment description: WIP: Bug 1654054 - Port videocontrols to Fluent. r=mtigley!,mhowell! → Bug 1654054 - Port videocontrols to Fluent. r=#pip-reviewers!
See Also: → 1763899
Attachment #9265553 - Attachment is obsolete: true
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dde97d800713
Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/164e5a97cc41
Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod

Backed out for causing mochitest failures on browser_nimbusMessageFirstTimePip.js

Flags: needinfo?(nbaumgardner)
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f9ad49eb131
Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/2b6a67ada4d3
Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod

Backed out for causing bc failures on browser_nimbusShowIconOnly.js

Backout link

Push with failures

Failure log 1 // Failure log 2

Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e881fd99de24
Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/549ab6fd1f57
Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Flags: needinfo?(nbaumgardner)
Regressions: 1771650
Blocks: 1772335
No longer blocks: 1772335
You need to log in before you can comment on or make changes to this bug.