Port videocontrols to Fluent
Categories
(Toolkit :: Video/Audio Controls, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: mconley, Assigned: niklas)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files, 1 obsolete file)
The localization team requested as part of the deal for allowing new DTDs into the tree for bug 1653663, that we commit to porting all of videocontrols.js to Fluent for an upcoming release.
This will require platform support to allow DOMLocalization into the UAWidget scope (see bug 1504363).
Comment 1•4 years ago
|
||
As part of my work on bug 1496851, videocontrols.js can now use (and does use) Fluent. I only used Fluent for new strings, though. Existing DTD strings still need to be ported.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 4•3 years ago
|
||
Hi Guanlin! Just checking to see if you're still able to work on this?
Updated•3 years ago
|
Comment 5•3 years ago
|
||
Looks like we have a number of failures from the current patch: https://treeherder.mozilla.org/jobs?repo=try&revision=9abdec1234de1028a6b3ce2c59746967dc62b1b0
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 6•2 years ago
|
||
Removing needinfo on this since I haven't had time to investigate test failures recently.
Comment 7•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:jaws, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 8•2 years ago
|
||
Niklas and Katherine, could either of you like to pick this up?
Assignee | ||
Comment 9•2 years ago
|
||
I can take this
Reporter | ||
Comment 10•2 years ago
|
||
I actually had started tinkering with this on the side. It was the subject of my last Joy of Coding episode if you want to see where I got with it! (not tooo too far): https://www.youtube.com/watch?v=RJvfK84OjQ4
There are some gotchas here with test failures in toolkit/content/tests/widgets
. I traced at least part of it down to the fact that Fluent replaces nodes that have data-l10n-name
when doing translation as part of santization: https://searchfox.org/mozilla-central/rev/9d66919569655a8fae9b431550241c058fa85b8a/dom/l10n/L10nOverlays.cpp#359
this means that if the translation has not completed by the time the durationSpan
control is defined, it'll be pointed at the wrong DOM node (one that has been replaced, and is no longer connected to the document).
I'll post what I have so far in case you want to start with it (no obligation).
Updated•2 years ago
|
Reporter | ||
Comment 11•2 years ago
|
||
Original patch by Guanlin Cheng <chenggu3@msu.edu>.
Reporter | ||
Comment 12•2 years ago
|
||
Depends on D139742
Reporter | ||
Comment 13•2 years ago
|
||
The main porting patch might be useful at least to save you some rebasing effort. The "debugging" patch is various semi-successful half-baked stabs by myself to fix the test failures.
Assignee | ||
Comment 14•2 years ago
|
||
Thanks Mike!
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 15•2 years ago
|
||
Depends on D139742
Comment 16•2 years ago
|
||
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dde97d800713 Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod https://hg.mozilla.org/integration/autoland/rev/164e5a97cc41 Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod
Comment 17•2 years ago
|
||
Backed out for causing mochitest failures on browser_nimbusMessageFirstTimePip.js
- Backout link
- Push with failures
- Failure Log
- Failure line: PROCESS-CRASH | toolkit/components/pictureinpicture/tests/browser_nimbusMessageFirstTimePip.js | application crashed [@ CheckForBrokenChromeURL(nsILoadInfo*, nsIURI*)]
- log 2: https://treeherder.mozilla.org/logviewer?job_id=375220104&repo=autoland
- Log 3: https://treeherder.mozilla.org/logviewer?job_id=375218959&repo=autoland
Comment 18•2 years ago
|
||
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f9ad49eb131 Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod https://hg.mozilla.org/integration/autoland/rev/2b6a67ada4d3 Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod
Comment 19•2 years ago
|
||
Backed out for causing bc failures on browser_nimbusShowIconOnly.js
Reporter | ||
Comment 20•2 years ago
|
||
Looks like there's another usage of videocontrols.dtd here: https://searchfox.org/mozilla-central/rev/6da1ebe13b260efabd88eb98dec5fa8ee65987b2/toolkit/components/pictureinpicture/tests/browser_nimbusShowIconOnly.js#76
I think that's the last one.
Comment 21•2 years ago
|
||
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e881fd99de24 Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod https://hg.mozilla.org/integration/autoland/rev/549ab6fd1f57 Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod
Comment 22•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e881fd99de24
https://hg.mozilla.org/mozilla-central/rev/549ab6fd1f57
Assignee | ||
Updated•2 years ago
|
Description
•