Closed Bug 1654090 Opened 2 months ago Closed 2 months ago

Add py3 support for pywebsocket

Categories

(Testing :: Mochitest, enhancement, P2)

enhancement

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

Some mochitests rely on pywebsocket, from testing/mochitest/pywebsocket.

That code is several years old and not at all py3 compatible.

It looks like the project has moved to https://github.com/googlearchive/pywebsocket, but that says to use pywebsocket3 instead: https://github.com/GoogleChromeLabs/pywebsocket3.

pywebsocket3 is py3-compat, but not py2-compat: I think we'll need to support both for a while.

Looks like it supports Python 2 still:
https://github.com/GoogleChromeLabs/pywebsocket3/blob/master/setup.py#L47

Though vendoring both temporarily might be an easier upgrade path if updating to pywebsocket3 causes issues in the tests.

(In reply to Andrew Halberstadt [:ahal] from comment #2)

Looks like it supports Python 2 still:

Oh, thanks! I thought I read that it did not, but I can't find that now...probably I was mistaken. I'll try upgrading to pywebsocket3 for py2 and proceed if it is easy.

Depends on: 1654356

Update testing/mochitest/pywebsocket with the latest version available: pywebsocket3
is python 3 compatible. This keeps the basic structure of the old pywebsocket, but
changes the directory name to pywebsocket3 to reflect the project renaming.

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc83536b5d52
Replace testing/mochitest/pywebsocket with pywebsocket3; r=jmaher
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.