Closed Bug 1654174 Opened 4 years ago Closed 4 years ago

HTML select element change event: Error: getUserNameAndPasswordFields: input element required

Categories

(Toolkit :: Password Manager, defect, P4)

78 Branch
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- fixed

People

(Reporter: feedbro.reader, Unassigned)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

  1. Install Feedbro WebExtension: https://addons.mozilla.org/firefox/addon/feedbroreader/
  2. Open Feedbro reader (click the Feedbro WebExtension icon and select "Open Feed Reader")
  3. Click "Add folder" icon - use the name "foo" (without double quotes) - OK
  4. Click "Add feed" icon - (Feed URL: example.com, Title: yeah, Folder: foo) - press Save
  5. Click "Add feed" icon - change the Folder select value from "foo" to "Root"

Actual results:

-> in the background page Console there's an error right after you change the folder from "foo" to "Root":

Error: getUserNameAndPasswordFields: input element required
getUserNameAndPasswordFields resource://gre/modules/LoginManagerChild.jsm:2510
handleEvent resource://gre/modules/LoginManagerChild.jsm:257
receiveMessage resource://gre/actors/SelectChild.jsm:268
receiveMessage resource://gre/actors/SelectChild.jsm:465

Expected results:

There should be no such error. Feedbro does not have an event listener in the folder element so this is entirely something incorrectly generated by Firefox.

Here's a quite minimal Test Case as a standalone WebExtension that can be used to reproduce this bug.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → DOM: Core & HTML
Product: Firefox → Core

Since the error is from toolkit/components/passwordmgr/:

Component: DOM: Core & HTML → Password Manager
Product: Core → Toolkit
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(severin.mozilla)
Keywords: regression

Thanks for filing @Voltron! I was able to reproduce on Firefox 78.0.2 (release), but not on Nightly or when building from Central (I tested each both with FeedBro and your minimal example). So whatever the bug was, it seems likely that it's been fixed.

If this has a major impact on your workflow we might consider working out what the fix was and uplifting it to an earlier version (since 80 will take a while to be released), but I didn't notice any user facing problem here. If I'm wrong please reopen the ticket, describe the impact, and we can prioritize the work.

Thanks again!

Severity: -- → S4
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(severin.mozilla)
Priority: -- → P4
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: