1654195 - Make text-combine-upright non-animatable

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Brian Birtles (:birtles)]

According to the spec it is not animatable:

https://drafts.csswg.org/css-writing-modes-4/#propdef-text-combine-upright

But in our implementation it is discrete:

https://searchfox.org/mozilla-central/rev/9b282b34b5aa0f836beb735656c55efb2cc4c617/servo/components/style/properties/longhands/inherited_text.mako.rs#356

Comment 1

[Brian Birtles (:birtles)]

Bug 1653353 added some tests for this.

Comment 2

[Brian Birtles (:birtles)]

This should fail a few tests I hope:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=edf49cc4b02c0951e77d8d996e621d641022dfd2

Comment 3

[Brian Birtles (:birtles)]

Attachment: Bug 1654195 - Make text-combine-upright not animatable; r?boris

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a24dbf67be69
Make text-combine-upright not animatable; r=boris

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a24dbf67be69

Comment 6

[Rachel Andrew]

I've updated the formal data, and BCD for this property, and added a note in the Firefox 81 release notes.