Closed Bug 1654258 Opened 7 months ago Closed 6 months ago

Package all activity-stream css files and load them using the internal chrome: protocol

Categories

(Core :: Security: CAPS, task, P2)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file)

No description provided.
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e29d13db9888
Package all activity-stream css files and load them using the internal chrome: protocol. r=mconley,k88hudson

(In reply to Alexandru Michis [:malexandru] from comment #3)

Backed out changeset e29d13db9888 for causing failures in browser_all_files_referenced.js

Mike, it seems when running browser_all_files_referenced.js there are some unexpected errors. E.g. resource://activity-stream/data/content/assets/glyph-add-16.svg can not be referenced. Reason being is that glyph-add-16.svg is loaded using background-image: url("../data/content/assets/glyph-add-16.svg"); }.

I assume have to update those cases as well and load them using 'chrome:' URIs, right? Before going down that route I wanted to double check with you that this is the right way to go - what do you think?

Flags: needinfo?(ckerschb)
Flags: needinfo?(mconley)

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #4)

I assume have to update those cases as well and load them using 'chrome:' URIs, right? Before going down that route I wanted to double check with you that this is the right way to go - what do you think?

Yep, putting the full chrome: URIs in there seems like the right move.

Flags: needinfo?(mconley)
Depends on: 1662654
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd82ed10e8e7
Package all activity-stream css files and load them using the internal chrome: protocol. r=mconley,k88hudson,perftest-reviewers,zombie,sparky
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Regressions: 1664120
Regressions: 1669634
You need to log in before you can comment on or make changes to this bug.