1654258 - Package all activity-stream css files and load them using the internal chrome: protocol

Status: RESOLVED FIXED

(Core :: Security: CAPS, task, P2)

Comment 1

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

Attachment: Bug 1654258: Package all activity-stream css files and load them using the internal chrome: protocol. r=mconley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e29d13db9888
Package all activity-stream css files and load them using the internal chrome: protocol. r=mconley,k88hudson

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset e29d13db9888 for causing failures in browser_all_files_referenced.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5362ccf3ec882d7a5ce5b659a1d7a673b0f1075d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=e29d13db9888cec75e8e368a76f159e46d9a1c68&searchStr=bc&selectedTaskRun=BMS-pC9uQhusdGpKIdygZA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311480486&repo=autoland&lineNumber=3271

Comment 4

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

(In reply to Alexandru Michis [:malexandru] from comment #3)

Backed out changeset e29d13db9888 for causing failures in browser_all_files_referenced.js

Mike, it seems when running browser_all_files_referenced.js there are some unexpected errors. E.g. resource://activity-stream/data/content/assets/glyph-add-16.svg can not be referenced. Reason being is that glyph-add-16.svg is loaded using background-image: url("../data/content/assets/glyph-add-16.svg"); }.

I assume have to update those cases as well and load them using 'chrome:' URIs, right? Before going down that route I wanted to double check with you that this is the right way to go - what do you think?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #4)

I assume have to update those cases as well and load them using 'chrome:' URIs, right? Before going down that route I wanted to double check with you that this is the right way to go - what do you think?

Yep, putting the full chrome: URIs in there seems like the right move.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd82ed10e8e7
Package all activity-stream css files and load them using the internal chrome: protocol. r=mconley,k88hudson,perftest-reviewers,zombie,sparky

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cd82ed10e8e7