1654260 - Package all formautofill css files and load them using the internal chrome: protocol

Status: RESOLVED FIXED

(Core :: Security: CAPS, task, P2)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1654260: Package all formautofill css files and load them using the internal chrome: protocol. r=mattn

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e49050b442ab
Package all formautofill css files and load them using the internal chrome: protocol. r=MattN

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59278c955714
Backed out changeset e49050b442ab for bc failures browser_all_files_referenced.js. CLOSED TREE

Comment 4

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e49050b442ab669b81df5ba4a02c8798c3dc2451&searchStr=bc&failure_classification_id=2&selectedTaskRun=IGlmSo3zRA65BS5iGEarng.1

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=311295705&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=311289536&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/59278c955714

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9808122e5ba5
Package all formautofill css files and load them using the internal chrome: protocol. r=MattN

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on browser/extensions/formautofill/test/browser/browser_autocomplete_footer.js and browser/base/content/test/static/browser_all_files_referenced.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=9808122e5ba59002cfd642a5cb5e2f17ef0da563&searchStr=bc&failure_classification_id=2&selectedTaskRun=XedRhf9PTfO6eDSOvu4TZw.0

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=311304105&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=311303526&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/dc5542794ea780eda89db74b1ffd7cfcd85c568b

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Cosmin Sabou [:CosminS] from comment #6)

Backed out for bc failures on browser/extensions/formautofill/test/browser/browser_autocomplete_footer.js and browser/base/content/test/static/browser_all_files_referenced.js

Huh, on it!

Comment 8

[Christoph Kerschbaumer [:ckerschb]]

Hey Matt, I guess I need a little help moving forward here. Probably we have to update jar.mn in the end, but I don't know exactly what we want to end up with.

There are two tests failing:

browser/extensions/formautofill/test/browser/browser_autocomplete_footer.js

which logs the following two lines which are important:

• Chrome file doesn't exist: /home/ckerschb/source/mc-dbg/dist/bin/browser/features/[e-mail]/chrome/content/autocomplete-item-shared.css
• Chrome file doesn't exist: /home/ckerschb/source/mc-dbg/dist/bin/browser/features/[e-mail]/chrome/content/autocomplete-item.css

browser/base/content/test/static/browser_all_files_referenced.js

In this test there is a comment around dynamically registering formautofill using chrome: and resource:

Can you provide some guidance on what the best approach is here?

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ckerschb, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #9)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ckerschb, could you have a look please?

Patch was backed out - I have to fix up the patch before we can re-land.

Comment 11

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #8)

Can you provide some guidance on what the best approach is here?

I think I figured it out, probably we can simply remove res/ (skin/shared/*) and load all *.css using chrome: - I'll give that a try.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf10e3032361
Package all formautofill css files and load them using the internal chrome: protocol. r=MattN,Gijs

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cf10e3032361