1654266 - Stopping display share stops sharing all streams

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

We should only stop the most recent display share when the user clicks the "Stop Sharing" button.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1649032

Comment 2

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Visit https://talky.io
2. Click on "Start a Chat"
3. Grant access to the camera and microphone
4. Click "Join Call"
5. In the Talky chat room, click "Share screen"
6. Share a screen or window (this seems to reproduce reliably if you share a whole screen)
7. Click "Stop sharing" in the WebRTC global sharing indicator

ER:

Sharing of the screen / window should stop.

AR:

All streams, including the microphone and camera stop being shared.

This doesn't always reproduce reliably if you only share a window, which is frustrating. We should try to figure out why.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1654266 - Make sure the 'Stop Sharing' button in the WebRTC indicator only stops displays, and not mic/camera streams. r?pbz!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e8a09f76574
Make sure the 'Stop Sharing' button in the WebRTC indicator only stops displays, and not mic/camera streams. r=pbz

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4e8a09f76574

Comment 6

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue using Firefox 80.0a1 (20200722215545) on Windows 10x64. When clicking Stop Sharing from WebRTC Indicator all streams including the microphone and camera are closed.
The issue is verified fixed with Firefox 80.0b1 (20200728204253) on Windows 10x64, macOS 10.12 and Ubuntu 18.04. After clicking Stop Sharing button from the WebRTC global sharing indicator only the shared screen/window is stopped.

Comment 7

[Daniel Bodea [:danibodea]]

I can also confirm that the "Stop Sharing" button stops ALL SHARING STREAMS. Confirmed on Windows 10, Windows 7, Mac OS 10.15 on Nightly 84.0a1 and Beta v83.0b4.