1654333 - [wpt-sync] Sync PR 24686 - Make a WPT for renameSync fail if renameSync is not implemented.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24686 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24686
Details from upstream follow.

Richard Stotz <[e-mail]> wrote:

Make a WPT for renameSync fail if renameSync is not implemented.

As a missing function gives a TypeError, one of the WPTs for renameSync
would pass when renameSync is not implemented, which is
counterintuitive.

Bug: 914488
Change-Id: I4c16cf55723b772b0cba5c5c3acd376165e25591
Reviewed-on: https://chromium-review.googlesource.com/2310531
WPT-Export-Revision: 1810cc0bd156ec341a356925492deecf31062093

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcf39f9539d2383160fb7ac6522da9f7f84d3bd8

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 5 subtests

Status Summary

Firefox

FAIL : 12
ERROR : 5
NOTRUN: 8

Chrome

OK : 5
PASS : 25

Safari

FAIL : 9
ERROR : 5
NOTRUN: 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/native-io/rename_async_failure_handling.tentative.https.any.html: ERROR (Chrome: OK, Safari: ERROR)
Failed nativeIO.rename does not unlock the source.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
nativeIO.rename does not overwrite an existing file.: FAIL (Chrome: PASS, Safari: FAIL)
nativeIO.rename does not allow renaming an open file.: FAIL (Chrome: PASS, Safari: FAIL)
Failed nativeIO.rename does not unlock the destination.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
nativeIO.rename does not allow renaming from or to invalid names.: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/rename_async_failure_handling.tentative.https.any.worker.html: ERROR (Chrome: OK, Safari: ERROR)
Failed nativeIO.rename does not unlock the source.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
nativeIO.rename does not overwrite an existing file.: FAIL (Chrome: PASS, Safari: FAIL)
nativeIO.rename does not allow renaming an open file.: FAIL (Chrome: PASS, Safari: FAIL)
Failed nativeIO.rename does not unlock the destination.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
nativeIO.rename does not allow renaming from or to invalid names.: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/rename_async_failure_handling.tentative.https.any.serviceworker.html: ERROR (Chrome: OK, Safari: ERROR)
Failed nativeIO.rename does not unlock the source.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
nativeIO.rename does not overwrite an existing file.: FAIL (Chrome: PASS, Safari: FAIL)
nativeIO.rename does not allow renaming an open file.: FAIL (Chrome: PASS, Safari: FAIL)
Failed nativeIO.rename does not unlock the destination.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
nativeIO.rename does not allow renaming from or to invalid names.: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/rename_async_failure_handling.tentative.https.any.sharedworker.html: ERROR (Chrome: OK, Safari: ERROR)
Failed nativeIO.rename does not unlock the source.: NOTRUN (Chrome: PASS)
nativeIO.rename does not overwrite an existing file.: FAIL (Chrome: PASS)
nativeIO.rename does not allow renaming an open file.: FAIL (Chrome: PASS)
Failed nativeIO.rename does not unlock the destination.: NOTRUN (Chrome: PASS)
nativeIO.rename does not allow renaming from or to invalid names.: FAIL (Chrome: PASS)
/native-io/rename_sync_failure_handling.tentative.https.any.worker.html: ERROR (Chrome: OK, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3556ee4f5be8
[wpt PR 24686] - Make a WPT for renameSync fail if renameSync is not implemented., a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3556ee4f5be8