1654397 - ChromiumCDMVideoDecoder should populate the encryption scheme on config

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

ChromiumCDMVideoDecoder sets up data to init the CDM[0]. Historically this didn't include a crypto scheme as the cenc scheme was assumed. However, with CDM interface 10 we can pass a scheme as part of the init config, but are not doing so.

Not having this data doesn't seem to have caused issue so far. I appear to have overlooked populating it here when the CDM added the structures for it. However, we should populate such data now that the CDM lets us. Especially since debugging the CDM can be so opaque.

[0] https://searchfox.org/mozilla-central/rev/3b6958c26049c1e27b2790a43154caaba9f6dd4a/dom/media/platforms/agnostic/eme/ChromiumCDMVideoDecoder.cpp#74

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1654397 - Set crypto scheme when initializing video decoder CDM. r?alwu,dminor

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2969f3de028f
Set crypto scheme when initializing video decoder CDM. r=alwu

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2969f3de028f