[wpt-sync] Sync PR 24692 - [css-lists] Fix marker not correctly updated in legacy layout
Categories
(Core :: Layout: Generated Content, Lists, and Counters, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24692 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24692
Details from upstream follow.
Oriol Brufau <obrufau@igalia.com> wrote:
[css-lists] Fix marker not correctly updated in legacy layout
If a list item contains a block box, the layout tree is initially like:
LayoutListItem {LI}
LayoutBlockFlow (anonymous)
LayoutListMarker {::marker}
LayoutBlockFlow {P}
LayoutText #textHowever, an outside ::marker should appear in the same line as the first
non-marker text of the list item. Therefore, it's changed into:LayoutListItem {LI}
LayoutBlockFlow (anonymous)
LayoutBlockFlow {P}
LayoutListMarker {::marker}
LayoutText {#text}But this was not happening when dynamically toggling list-style-type
between 'none' and some other value. The reason was that there was a
'NormalChildNeedsLayout()' condition, which would hold the 1st time, but
in following layouts it would be false.This patch just removes that condition.
Bug: 1107783
TEST=external/wpt/css/css-lists/change-list-style-type-002.html
Change-Id: Ic82f1a474b0a0ddf2f2aab8a60afac299aa6e2d1
Reviewed-on: https://chromium-review.googlesource.com/2310359
WPT-Export-Revision: 0450a103cf00047cd1b821d17c026040d0eb2bb3
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2e199606f083217f7ba167822b086d54c37cdc9
Assignee | ||
Comment 2•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1e012c380a7cb0625b61be0c8fd4847fa53024c
Assignee | ||
Comment 3•4 years ago
|
||
CI Results
Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests
Status Summary
Firefox
PASS: 2
Chrome
PASS: 2
Safari
PASS: 2
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a7ba5121b7d [wpt PR 24692] - [css-lists] Fix marker not correctly updated in legacy layout, a=testonly
Comment 5•4 years ago
|
||
bugherder |
Description
•