1654430 - 200ms sleep on mainthread when inserting/removing USB/bluetooth cam/mic/headset

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

We have a PR_Sleep(200) on mainthread here whenever the user inserts or removes a USB or bluetooth camera, mic or speaker device. 😬

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1654430 - Replace 200ms mainthread sleep on inserting/removing USB/bluetooth cam/mic/speaker with WaitFor() promise.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e2fb6f29963
Replace 200ms mainthread sleep on inserting/removing USB/bluetooth cam/mic/speaker with WaitFor() promise. r=achronop

Comment 3

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 7e2fb6f29963 (bug 1654430) for mda failures at dom/media/tests/mochitest/test_peerConnection_addAudioTrackToExistingVideoStream.html

Backout: https://hg.mozilla.org/integration/autoland/rev/097d8ca0911f24f5c7358bd603b984677f03956b

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7e2fb6f29963825f09c5a75aac370a3c3fef2301

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311288259&repo=autoland&lineNumber=15771

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

This patch seems to expose various timing issues that I can't repro locally (on macOS).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jib, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1654430 - Reorder devicechange event tests in test_ondevicechange.html

Depends on D84458

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1654430 - Update waitForRtpFlow() mochitest helper to use sender/receiver.getStats.

Depends on D89081

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1654430 - Fix mDeviceIDs to only track real devices and not be overwritten by other enumerateDevices requests.

Depends on D89082

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/788a6c7c52f1
Replace 200ms mainthread sleep on inserting/removing USB/bluetooth cam/mic/speaker with WaitFor() promise. r=achronop
https://hg.mozilla.org/integration/autoland/rev/0f1db7f155cb
Wait for ended events to have fired on other documents to not disrupt subsequent tests r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/495576ebc999
Update waitForRtpFlow() mochitest helper to use sender/receiver.getStats. r=ng
https://hg.mozilla.org/integration/autoland/rev/10a70b4fad32
Fix mDeviceIDs to only track real devices and not be overwritten by other enumerateDevices requests. r=pehrsons

Comment 11

[Narcis Beleuzu [:NarcisB]]

Backed out for mda failure on test_ondevicechange.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/b2f7303d043727ed8853ce1bd5c2aafdb536568d
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316489692&repo=autoland&lineNumber=17322

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/098923480472
Replace 200ms mainthread sleep on inserting/removing USB/bluetooth cam/mic/speaker with WaitFor() promise. r=achronop
https://hg.mozilla.org/integration/autoland/rev/7b08ec67dff7
Reorder devicechange event tests in test_ondevicechange.html r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/79124a30c1ce
Update waitForRtpFlow() mochitest helper to use sender/receiver.getStats. r=ng
https://hg.mozilla.org/integration/autoland/rev/9cca568a743b
Fix mDeviceIDs to only track real devices and not be overwritten by other enumerateDevices requests. r=pehrsons

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/098923480472
https://hg.mozilla.org/mozilla-central/rev/7b08ec67dff7
https://hg.mozilla.org/mozilla-central/rev/79124a30c1ce
https://hg.mozilla.org/mozilla-central/rev/9cca568a743b