Closed Bug 1654466 Opened 2 months ago Closed 2 months ago

Password Generation key icon is no longer blue after generating a password in a form with a confirm password field

Categories

(Toolkit :: Password Manager, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- unaffected
firefox80 --- verified
firefox81 --- verified

People

(Reporter: tbabos, Assigned: bdanforth)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached video Recording of the issue

Affected versions:
Latest Nightly 80.0a1 (2020-07-21) (64-bit)

Tested on:
Windows 7/10
MacOS

Steps to reproduce:

  1. Go to Wikipedia's register form
  2. Fill in the username
  3. Choose to generate a password in the password field

Expected:
The "Password Saved!" toast is displayed and the key icon should be of blue color since we auto-saved a generated password.

Actual:
The key icon is grey even if the toast was displayed.

Regression-range:
Found commit message:
Bug 1612258 - Show/adjust the dismissed login capture doorhanger in response to input events in the password & username field. r=MattN,severin
Differential Revision: https://phabricator.services.mozilla.com/D81377

Notes:
Didn't observe this issue while verifying Bug 1612258 but it was catched during our Nightly build validations.

Flags: needinfo?(bdanforth)
Severity: -- → S3
Flags: needinfo?(bdanforth)
Priority: -- → P1
Flags: needinfo?(bdanforth)
Assignee: nobody → bdanforth
Status: NEW → ASSIGNED
Summary: Password Generation key icon is no longer blue after generating a password → Password Generation key icon is no longer blue after generating a password in a form with a confirm password field
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/cf8c30f7059c
Don't send a 'PasswordManager:onPasswordEditedOrGenerated' message when a confirm password field is filled with a generated password. r=MattN
Flags: needinfo?(bdanforth) → qe-verify+

Comment on attachment 9167955 [details]
Bug 1654466 - Don't send a 'PasswordManager:onPasswordEditedOrGenerated' message when a confirm password field is filled with a generated password. r=MattN

Beta/Release Uplift Approval Request

  • User impact if declined: When the user generates a password on a page with a confirm field, the key icon that shows up in the URL bar will be grey instead of blue, or it may flash blue briefly before returning to its default grey color.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See the Description for the bug.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This bug (and the fix in this patch) only affects pages with confirm password fields when the user opts to use a generated password.

This triggers an autosave feature which relies in part on a heuristic that this patch modifies. In the extremely remote situations (see commit message) where the heuristic is wrong, the consequence is that the value in the confirm password field will continue to be autosaved on "change" events.

  • String changes made/needed:
Attachment #9167955 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Verified-fixed on latest Nightly 81.0a1 (2020-08-12) (64-bit) on Windows 10, MacOS 10.13 and Ubuntu 18.04. Waiting for potential Uplift.

Comment on attachment 9167955 [details]
Bug 1654466 - Don't send a 'PasswordManager:onPasswordEditedOrGenerated' message when a confirm password field is filled with a generated password. r=MattN

regression fix for password management, approved for 80.0b8

Attachment #9167955 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified-fixed on latest Beta 80.0b8 on Windows 10, MacOS 10.13.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.