Closed Bug 1654479 Opened 4 years ago Closed 4 years ago

xpcshell harness leaks file descriptors

Categories

(Testing :: XPCShell Harness, defect)

Product:
Testing
Component:
XPCShell Harness
Type:
defect

Tracking

(firefox-esr78 fixed, firefox80 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox-esr78 --- fixed
firefox80 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1654479 - Clear up processes after shutting them down in XPCShellTests.
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr78+
Details | Review

And when running the selftests on mac, we run out of file descriptors after a few tests and the later ones fail.

We don't send anything on stdin of these processes, and at least on mac,
that ends up leaking these pipe file descriptors, later leading to
failures in the xpcshell self tests.

Attachment #9165311 - Attachment description: Bug 1654479 - Don't set stdin to PIPE when invoking node and http3server. → Bug 1654479 - Clear up processes after shutting them down in XPCShellTests.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/72f036d4f84c
Clear up processes after shutting them down in XPCShellTests. r=gbrown

https://hg.mozilla.org/mozilla-central/rev/72f036d4f84c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
See Also: → 1689184

Comment on attachment 9165311 [details]
Bug 1654479 - Clear up processes after shutting them down in XPCShellTests.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Resolves xpcshell test failure
  • User impact if declined: None
  • Fix Landed on Version: 81
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a test-only patch
  • String or UUID changes made by this patch:
Attachment #9165311 - Flags: approval-mozilla-esr78?
Attachment #9165311 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: