1654483 - AssertionError: No line resembling a stack frame was found

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

The xpcshell self test fails on mac in testAssertStack, failing to find stack frames in the output from a nsIDebug2.assertion(). A MOZ_CRASH does happen, but there is not stack dump from the assertion like on e.g. Linux.

Comment 1

[Mike Hommey [:glandium]]

Turns out this is happening because the test is not skipped like it currently is due to some subtlety in my changes.

Comment 2

[Mike Hommey [:glandium]]

Scrap that, it's not currently skipped.

Comment 3

[Mike Hommey [:glandium]]

Turns out it's a manifestation of bug 1515229. We skip too many frames, so we skip over the nsDebugImpl::Assertion frame, and that's the last frame because we have JS code calling that through an xpcom vtable, so there aren't any frames left to be printed out, and the test fails because of that.

Comment 4

[Mike Hommey [:glandium]]

Actually, there is something that can be done here, independently of bug 1515229: make the caller of nsDebugImpl::Assertion visible to the stack walker.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1654483 - Enable the CFI directives for NS_InvokeByIndex on macOS.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b825fad12b06
Enable the CFI directives for NS_InvokeByIndex on macOS. r=froydnj

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b825fad12b06

Comment 8

[Mitchell Hentges [:mhentges] 🦀]

Comment on attachment 9165806 [details]
Bug 1654483 - Enable the CFI directives for NS_InvokeByIndex on macOS.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Resolves xpcshell test failures
• User impact if declined: None
• Fix Landed on Version: 81
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a build-only patch
• String or UUID changes made by this patch:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/309e809c2c47