1654645 - metrics data is not making it into deletion-request pings

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Travis Long [:travis_]]

This specifically affects apps that are adding legacy ids to the deletion-request ping. Older versions of Glean, like used by Firefox for Fire TV do not seem to have this issue, but the latest versions of Glean are not reporting the metrics in the deletion request ping.

According to the logs, the storage is empty so I suspect it is either not getting stored correctly due to the deletion-request / deletion_request differences for some reason, or it's getting cleared before the deletion request is sent (not sure how this could happen for user lifetime metrics...)

Comment 1

[Travis Long [:travis_]]

Looks like chutten may have pointed us in the right direction:

ping names are kebab case, with an exception for legacy deletion_request

But the defined "built-in" ping name is still deletion_request which doesn't allow us to set the send_in_pings to deletion-request without getting the following error: ERROR: MISSPELLED_PING: legacy.ids.client_id: Ping 'deletion-request' seems misspelled. Did you mean 'deletion_request'?

Comment 2

[Travis Long [:travis_]]

Attachment: GitHub Pull Request

Comment 3

[Michael Droettboom [:mdroettboom]]

The one additional piece of information that convinced me this bug is on the right track is that the ping that glean-core sends is called deletion-request.

So, in summary, the lint is leading folks astray here...?

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1093

Comment 5

[Travis Long [:travis_]]

Per :mdroettboom's suggestion, if a consuming application cannot update to a newer version of Glean, this can be solved by adding the no_lint: [MISSPELLED_PING] to the metric and then it should be possible to go ahead and update the send_in_pings field from deletion_request to deletion-request.

Comment 6

[Travis Long [:travis_]]

This has landed in A-C, and been verified as working for Echo Show, so closing as FIXED.