Closed Bug 1654663 Opened 4 years ago Closed 4 years ago

vendored glean_parser library should only be available to run_glean_parser

Categories

(Firefox Build System :: General, task)

task

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: mhentges, Assigned: mhentges)

References

Details

Attachments

(1 file)

When we implement Glean telemetry, we can't vendor the top-level Glean package (glean_sdk) because it has a native component - instead, we install it to the --user environment.
glean_sdk has associated dependencies, and one of them is glean_parser, which we already have vendored in-tree.

This is causing issues where, when we import glean_sdk, most dependencies are fetched from the --user pip environment, but (a very old) glean_parser is imported from in-tree.
There's only one consumer of the vendored glean_parser: run_glean_parser.py.

To solve this, we can:

  1. Only use the vendored glean_parser library within run_glean_parser.py.
  2. Grab all glean dependencies from the --user environment when importing Glean
Assignee: nobody → mhentges
Status: NEW → ASSIGNED

In preparation for Glean telemetry, we scope the availability of the out-of-date vendored
"glean_parser" library to its one usage: "run_glean_parser.py".

This allows Glean telemetry to load its modern "glean_parser" dependency from the
"--user" package environment.

Depends on D84566

Pushed by mhentges@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aae7491870dd
Removes glean_parser from virtualenv_packages.txt r=firefox-build-system-reviewers,rstewart
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
See Also: → 1635260
See Also: → 1655760
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: