Closed Bug 1654665 Opened 4 years ago Closed 1 year ago

Password field should be unmasked when editing

Categories

(Firefox :: about:logins, enhancement, P3)

80 Branch
enhancement

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox80 --- wontfix
firefox113 --- fixed

People

(Reporter: tgiles, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxcm-ui])

Attachments

(1 file, 1 obsolete file)

Steps to reproduce

  1. Open browser and navigate to "about:logins" page
  2. Activate the "Create New Login" button
  3. Navigate to the "Password" field
  4. Fill in the password field with any characters

Expected result

  • Password is unmasked

Actual result

  • Password is masked

katieC: Does this sound like we discussed earlier on 7/22/20? We discussed a few different bugs, I just want to make sure this particular bug is accurate.

Flags: needinfo?(kcaldwell)

Just to clarify a bit katieC, this will simply set the reveal password toggle to be checked upon entering create mode. We would not add any behavior around focus/blur for unmasking/masking in this bug. That is for later consideration -- is that right?

UX Recommendation:
When the user CREATES a new login, the password field is empty (nothing to mask) - show the password as the user types so they can see what they are entering and make edits as needed. (They can click the show/hide eye icon to mask the password should they choose.)

So yes, in create mode, set the reveal password to checked. thanks!

Flags: needinfo?(kcaldwell)
Assignee: nobody → tgiles
Status: NEW → ASSIGNED
See Also: → 1627366

(In reply to katieC from comment #2)

When the user CREATES a new login, the password field is empty (nothing to mask) - show the password as the user types so they can see what they are entering and make edits as needed. (They can click the show/hide eye icon to mask the password should they choose.)

FWIW I wonder if this will be unexpected if someone is creating a new login and another person is within eyesight (e.g. they are going to type their password into the create form and they expect it to be masked like password fields normally are).

Severity: -- → N/A
Priority: -- → P3
Attachment #9165683 - Attachment is obsolete: true
Assignee: tgiles → nobody
Status: ASSIGNED → NEW

The behavior must be the same when editing or creating a login.

The field should be unmasked when user focuses it. They are editing it - forcing to click "Show password", return focus, edit and click "Show password" again to hide is not helpful.

Shoulder surfing is an issue for sure, but in this scenario user focused the password field to edit it, it is expected that they will show password.

Summary: Password field should be unmasked when creating a new login → Password field should be unmasked when editing
Whiteboard: [fxcm-ui]
Blocks: 1706886
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Attachment #9320033 - Attachment description: WIP: Bug 1654665 - Unmask password field when editing and field is focused. r=#credential-management-reviewers → Bug 1654665 - Unmask password field when editing and field is focused. r=#credential-management-reviewers
Attachment #9320033 - Attachment description: Bug 1654665 - Unmask password field when editing and field is focused. r=#credential-management-reviewers → WIP: Bug 1654665 - Unmask password field when editing and field is focused. r=#credential-management-reviewers
Attachment #9320033 - Attachment description: WIP: Bug 1654665 - Unmask password field when editing and field is focused. r=#credential-management-reviewers → Bug 1654665 - Unmask password field when editing and field is focused. r=#credential-management-reviewers
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e29e34147c6
Unmask password field when editing and field is focused. r=credential-management-reviewers,sgalich
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Regressions: 1831248
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: