Closed Bug 1654675 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 24701 - [NativeFS] Keep directory iterator alive while it has pending promises.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24701 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24701
Details from upstream follow.

Marijn Kruisselbrink <mek@chromium.org> wrote:

[NativeFS] Keep directory iterator alive while it has pending promises.

Should hopefully also fix test flakiness where tests seemed to already
be running into this.

Fixed: 1074123
Change-Id: If57c8d6f622c17d795bc1429f66485cda94befd2
Reviewed-on: https://chromium-review.googlesource.com/2313763
WPT-Export-Revision: 2d2dbfd93b76e0ab4ffdf52aa6c0401209e79a2c

PR 24701 applied with additional changes from upstream: 6dd4527974f68f3c904efb3910899ef641358c2e

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
FAIL: 12

Chrome

OK : 2
FAIL: 12

Safari

OK : 2
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/native-file-system/sandboxed_FileSystemDirectoryHandle-iteration.https.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
values: full iteration works: FAIL (Chrome: FAIL, Safari: FAIL)
returning early from an iteration doesn't crash: FAIL (Chrome: FAIL, Safari: FAIL)
entries: full iteration works: FAIL (Chrome: FAIL, Safari: FAIL)
iteration while iterator gets garbage collected: FAIL (Chrome: FAIL, Safari: FAIL)
@@asyncIterator: full iteration works: FAIL (Chrome: FAIL, Safari: FAIL)
keys: full iteration works: FAIL (Chrome: FAIL, Safari: FAIL)
/native-file-system/sandboxed_FileSystemDirectoryHandle-iteration.https.any.worker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
values: full iteration works: FAIL (Chrome: FAIL, Safari: FAIL)
returning early from an iteration doesn't crash: FAIL (Chrome: FAIL, Safari: FAIL)
entries: full iteration works: FAIL (Chrome: FAIL, Safari: FAIL)
iteration while iterator gets garbage collected: FAIL (Chrome: FAIL, Safari: FAIL)
@@asyncIterator: full iteration works: FAIL (Chrome: FAIL, Safari: FAIL)
keys: full iteration works: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/native-file-system/sandboxed_FileSystemDirectoryHandle-iteration.https.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/native-file-system/sandboxed_FileSystemDirectoryHandle-iteration.https.any.worker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a63aad7e3986
[wpt PR 24701] - [NativeFS] Keep directory iterator alive while it has pending promises., a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.