1654699 - Update core-graphics/core-foundation

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1654699. Update core-foundation/core-graphics.

This includes updates to authenticator, cubeb-coreaudio,
metal, gfx-backend-vulkan, gfx-backend-metal

libloading is duplicated because of ash

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45fc4a780b2b
Update core-foundation/core-graphics. r=kvark,keeler,chunmin

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 45fc4a780b2b (Bug 1654699) for causing failures regarding AudioStream position.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3d260235d84cf4fa2becad03ceec0bd6cd09784e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&tochange=3d260235d84cf4fa2becad03ceec0bd6cd09784e&fromchange=fdfccf41210646069d39d8b1c131c407af68740f

Logs:

• mda failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310880303&repo=autoland&lineNumber=2113
  https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Cwith%2Csocket%2Cprocess%2Ctest-macosx1014-64%2Fdebug-mochitest-media-spi-e10s%2Cmda1&tochange=45fc4a780b2b4a9e047eceba73b39b988f719c58&fromchange=fdfccf41210646069d39d8b1c131c407af68740f
• webgl failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310878908&repo=autoland&lineNumber=1896
• wpt failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310878862&repo=autoland&lineNumber=19337

All failures have the assertion line complaining about "AudioStream position shouldn't go backward: 'pos >= mLastGoodPosition'"

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Chun-Min, given the audio failure this is probably caused by the cubeb-coreaudio change.

Comment 5

[C.M.Chang[:chunmin]]

Ah, I guess it's probably caused by cubeb-coreaudio #101. It was merged before cubeb-coreaudio #104. We know the position is inaccurate and it should be fixed in cubeb-coreaudio #99. We add some code to make sure the position is increased monotonically.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Chun-Min, is it possible to switch to a branch that doesn't have the those other changes, but does have the core-foundation-sys bump so that we can get this landed without having to wait for https://github.com/ChunMinChang/cubeb-coreaudio-rs/pull/99?

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Paul confirmed that it's ok to land with current cubeb-coreaudio with cubeb-coreaudio #99.
I have a try push with the media tests here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=65206e8bc24c467c053d57f6ee6d787d45c375a3&selectedTaskRun=Sqtu8phhRX6iOiwqGqUsuQ.0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9702b4a4f53c
Update core-foundation/core-graphics. r=kvark,keeler,jcj,chunmin

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out for gtest failures

backout: https://hg.mozilla.org/integration/autoland/rev/12546a93754fc73b87d6c5775af1bcfba8220a02

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Ucv4bzlMTeS9yT-ZxqOVlQ.0&searchStr=os%2Cx%2C10.14%2Cdebug%2Ctest-macosx1014-64%2Fdebug-gtest-1proc%2Cgtest&revision=9702b4a4f53cebd57091f33837c596706e71f069

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310990910&repo=autoland&lineNumber=1803

[task 2020-07-24T18:08:19.669Z] 18:08:19 INFO - TEST-START | cubeb.stream_position
[task 2020-07-24T18:08:30.614Z] 18:08:30 WARNING - TEST-UNEXPECTED-FAIL | cubeb.stream_position | Expected equality of these values:
[task 2020-07-24T18:08:30.614Z] 18:08:30 INFO - position
[task 2020-07-24T18:08:30.615Z] 18:08:30 INFO - Which is: 328316
[task 2020-07-24T18:08:30.615Z] 18:08:30 INFO - last_position
[task 2020-07-24T18:08:30.615Z] 18:08:30 INFO - Which is: 305366 @ /builds/worker/checkouts/gecko/media/libcubeb/gtest/test_sanity.cpp:549
[task 2020-07-24T18:08:30.615Z] 18:08:30 WARNING - TEST-UNEXPECTED-FAIL | cubeb.stream_position | test completed (time: 10945ms)

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Looks like more cubeb problems.

Comment 11

[C.M.Chang[:chunmin]]

I created a bmo1654699 branch for you to update the core-foundation, which updates the core-foundation without changing the position-related code.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d57a18caafb
Update core-foundation/core-graphics. r=kvark,keeler,jcj,chunmin

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3d57a18caafb