1654754 - Remove usage of actorHasMethod in grid inspector and highlighters-overlay

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Julian Descottes [:jdescottes]]

actorHasMethod has too many pitfalls to be reliably used.

https://searchfox.org/mozilla-central/rev/dcd9c2d2bc19d96d487825eb70c2333a4d60994e/devtools/client/inspector/grids/grid-inspector.js#417

      if (
        isSubgrid &&
        (await this.inspector.currentTarget.actorHasMethod(
          "domwalker",
          "getParentGridNode"
        ))
      ) {

https://searchfox.org/mozilla-central/rev/dcd9c2d2bc19d96d487825eb70c2333a4d60994e/devtools/client/inspector/shared/highlighters-overlay.js#129

    if (this._canGetParentGridNode === undefined) {
      this._canGetParentGridNode = await this.target.actorHasMethod(
        "domwalker",
        "getParentGridNode"
      );
    }

We should update the grid inspector to use traits instead of actorHasMethod.

However, it looks like this check was introduced for backward compatibility and can probably be simply removed. "getParentGridNode" should be defined on all domwalker actors.

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1654754 - [devtools] Remove actorHasMethod usage from grid inspector and highlighters-overlay

The backward compatibility code was introduced in FF69 and can be removed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9e70c09985e
[devtools] Remove actorHasMethod usage from grid inspector and highlighters-overlay r=rcaliman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b9e70c09985e