1654756 - Icon is missing if a site is added as a one-click search engine while the page is not fully loaded

Status: NEW

(Firefox :: Search, defect, P3)

Description

[Oana Botisan, Desktop Release QA]

Attachment: icon missing with non-ascii characters.gif

** Proposed severity:**

• S4

Affected versions

• Firefox ESR 78.1
• Firefox 79.0
• Firefox 80.0a1

Affected platforms

• Windows 10 x64
  *Ubuntu 20.04 x64
• macOS 10.15

Precondition:

• Open Firefox with a new profile.
• Enable the search bar from about:preferences#search by clicking on "Add search bar in toolbar" option.

Steps to reproduce

1. Go to https://www.youtube.com/ or https://www.baidu.com/.
2. Click on the magnifying glass, then select "Add <search engine>" before the page is fully loaded.

Expected result

• The icon is displayed in one-click search engine list.

Actual result

• The icon is not displayed at all (baidu) or only after a refresh (youtube).

Regression range

• This is a regression because I can't reproduce the issue on Nightly build from 2018-01-20.

Additional notes

• This issue reproduces in about:preferences#search.
• Please look at the attached gif.

Comment 1

[Oana Botisan, Desktop Release QA]

Regression range:

• Last good: 2018-08-28
• First bad: 2018-08-29
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3205543f957cd2a6905486d73aa897535fdd9825&tochange=b75561ff5ffec3164338952adfe58620e5e3bc1d

Comment 2

[Florencia Di Ciocco, QA]

Hi,

I can still reproduce this bug on 85.0a1 (2020-12-10) (64-bit).

Regards, Flor

Comment 3

[Mark Banner (:standard8)]

Thanks, however no need to keep repeating it if they are still regressing. This is a lowish priority bug for us - a lot of users are unlikely to be doing that whilst a page hasn't yet loaded.