Closed Bug 1654759 Opened 4 years ago Closed 4 years ago

`./mach clang-format -c HEAD` fails

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mbrodesser-Igalia, Unassigned)

Details

./mach clang-format -c HEAD && g diff
Error running mach:

    ['clang-format', '-c', 'HEAD']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file clang-format| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: a bytes-like object is required, not 'str'

  File "/home/mirko/src/firefox/gecko2/python/mozbuild/mozbuild/code-analysis/mach_commands.py", line 1724, in clang_format
    self._clang_format_path, commit, output)
  File "/home/mirko/src/firefox/gecko2/python/mozbuild/mozbuild/code-analysis/mach_commands.py", line 2150, in _run_clang_format_diff
    diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
  File "/home/mirko/src/firefox/gecko2/python/mozbuild/mozbuild/code-analysis/mach_commands.py", line 2092, in _get_clang_format_diff_command
    pattern = pattern.replace('.*', '**')
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit

Now this works, so feel free to close this ticket.

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(ahal)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
Flags: needinfo?(ahal)
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.