1654803 - Crash in [@ mozilla::PermissionDelegateHandler::GetPermission]

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Description

[Sean Feng [:sefeng]]

This bug is for crash report bp-b155f6af-9835-48c2-abc4-d1f080200721.

Top 10 frames of crashing thread:

0 libxul.so mozilla::PermissionDelegateHandler::GetPermission extensions/permissions/PermissionDelegateHandler.cpp:265
1 libxul.so mozilla::dom::PermissionStatus::UpdateState dom/permission/PermissionStatus.cpp:86
2 libxul.so mozilla::dom::PermissionStatus::Init dom/permission/PermissionStatus.cpp:48
3 libxul.so mozilla::dom::PermissionStatus::Create dom/permission/PermissionStatus.cpp:24
4 libxul.so mozilla::dom:: dom/permission/Permissions.cpp:55
5 libxul.so mozilla::dom::Permissions::Query dom/permission/Permissions.cpp:75
6 libxul.so mozilla::dom::Permissions_Binding::query_promiseWrapper dom/bindings/PermissionsBinding.cpp:193
7 libxul.so bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ConvertExceptionsToPromises> dom/bindings/BindingUtils.cpp:3220
8 libxul.so js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:576
9 libxul.so Interpret js/src/vm/Interpreter.cpp:639

This is not happening a lot, only 2 crash reports from the a single user.

Looks like we are missing a null pointer check here?

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Probably this line:

if (topWC->IsInProcess()) {

should be updated to

if (topWC && topWC->IsInProcess()) {

Tim, could you take a look?

Comment 2

[Tim Huang[:timhuang]]

Sure thing.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1654803 - Fixing the crash issue in PermissionDelegateHandler::GetPermission(). r?baku!

At very rare situations, we won't be able to get the top level window
context. Perhaps, it's the case that the window has been detached from
the dom tree while checking the permission. So, we need to check the top
level window context before we really use it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe8a43ec580c
Fixing the crash issue in PermissionDelegateHandler::GetPermission(). r=baku

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fe8a43ec580c