make new dump_syms mandatory for automation jobs
Categories
(Firefox Build System :: General, task, P3)
Tracking
(Not tracked)
People
(Reporter: froydnj, Unassigned)
References
(Blocks 1 open bug)
Details
The actual task described by this bug's title is pretty straightforward: you add a bit of code similar to what we have for WINCHECKSEC
:
That runs into two trivial problems:
- AArch64 Windows isn't supported (well) by new
dump_syms
due to its new-fangled unwind information. We don't support the unwind information on the olddump_syms
, though, so maybe this is not a problem. - Bug 1621475 says that new
dump_syms
doesn't support mingw...or maybe just puts files in the wrong place, or something.
Both of these problems are easily overcome by platform checks in configure.
The remaining problem is that plain builds that we run don't set DUMP_SYMS
, and thus would fail with such a change. Options that I can see for handling this:
- Set
DUMP_SYMS
for such builds, sincedump_syms
is installed during bootstrap and we'd pick it up anyway. - Detect that we're doing plain builds (via
PERFHERDER_EXTRA_OPTIONS
, maybe?) and don't requireDUMP_SYMS
in such cases. - Don't dump symbols for plain builds (which we should probably be doing anyway...) and key the requirement of
DUMP_SYMS
off of whether symbol dumping is enabled or not. - Something else I haven't thought of.
Opinions?
Comment 1•4 years ago
|
||
If symbols aren't required or used for plain builds I'd go with 3.
Updated•4 years ago
|
Comment 2•3 years ago
|
||
It seems to me that this was fixed in bug 1686646 and plain builds also use the new dump_syms since it's picked up automatically. Also we've disabled building the old dump_syms altogether. Mike can you confirm this?
Comment 3•3 years ago
|
||
It would be bug 1641928, bug 1652870, bug 1654845 and bug 1588538.
Comment 4•3 years ago
|
||
Thanks!
Description
•