Closed Bug 1654940 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 24730 - Have CookieStore reject cookies with no name and no value.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox81 fixed)

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24730 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24730
Details from upstream follow.

Dylan Cutler <dylancutler@google.com> wrote:

Have CookieStore reject cookies with no name and no value.

The CookieStore spec recently changed to disallow setting cookies
using this API:

https://github.com/WICG/cookie-store/pull/150

This CL updates the implementation of CookieStore in Blink to
perform this additional check and updates the web platform
tests to reflect the new changes to the spec.

Bug:1108964
Change-Id: I1bc60332551308498509c0e8bbc6823bd8375ab8
Reviewed-on: https://chromium-review.googlesource.com/2316622
WPT-Export-Revision: a87d232b90d5b3e8924fcb44fec2120e2b1d6717

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL: 29

Chrome

OK : 3
PASS: 28
FAIL: 1

Safari

OK : 3
FAIL: 29

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookie-store/cookieStore_delete_arguments.tentative.https.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: OK, Safari: OK)
cookieStore.delete with path that does not start with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to subdirectory of the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete domain starts with ".": FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with empty name in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with positional empty name: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain that is not equal current host: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with get result: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with missing / at the end of path: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with positional name: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStore_delete_arguments.tentative.https.any.serviceworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: OK, Safari: OK)
cookieStore.delete with path that does not start with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to subdirectory of the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete domain starts with ".": FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with empty name in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with positional empty name: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain that is not equal current host: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with get result: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with missing / at the end of path: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with positional name: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/change_eventhandler_for_no_name_and_no_value.tentative.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: OK, Safari: OK)
Verify behavior of no-name and no-value cookies.: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/cookie-store/cookieStore_delete_arguments.tentative.https.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: OK, Safari: OK)
/cookie-store/cookieStore_delete_arguments.tentative.https.any.serviceworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: OK, Safari: OK)
/cookie-store/change_eventhandler_for_no_name_and_no_value.tentative.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9dd21bb3f50
[wpt PR 24730] - Have CookieStore reject cookies with no name and no value., a=testonly

https://hg.mozilla.org/mozilla-central/rev/f9dd21bb3f50

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.