Closed Bug 1655012 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24734 - [Perfect Negotiation] Migrate to non-racy setLocalDescription API.

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24734 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24734
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:

[Perfect Negotiation] Migrate to non-racy setLocalDescription API.

(This CL depends on WebRTC CL
https://webrtc-review.googlesource.com/c/src/+/179100 rolling.)

This CL migrates to the non-racy version of SetLocalDescription, i.e.
a version of SLD that invokes its callback immediately when the
operation completes rather than with a delay, ensuring that SLD can
resolve with the right states.

This CL adds a WPT that verifies calling SLD and SRD in a way that
without this CL would fail.

This CL also makes the RTCPeerConnection-perfect-negotiation.https WPT
expectations predictable: In Unified Plan, we always pass the first two
tests and (due to https://crbug.com/1060083) always fail the remaining
ones. In Plan B, we always Timeout (addTransceiver throws
asynchronously leaving a promise unresolved).

Bug: chromium:1071733
Change-Id: I21025226bd86e94456cc9a8c3deb980170d8bed8
Reviewed-on: https://chromium-review.googlesource.com/2292252
WPT-Export-Revision: 31a259faba15358d96f52963e3d3144392d5cc38

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/385b0823d131
[wpt PR 24734] - [Perfect Negotiation] Migrate to non-racy setLocalDescription API., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f62922d2fb93
[wpt PR 24734] - [Perfect Negotiation] Migrate to non-racy setLocalDescription API., a=testonly

https://hg.mozilla.org/mozilla-central/rev/f62922d2fb93

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.