1655084 - VoiceOver doesn't read aria-label on <nav> and aria-labelledby on a <div> with role="region"

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect, P1)

Description

[Emily McMinn :emcminn]

Attachment: test JSON for browser.aboutwelcome.overrideContent

This came up during an a11y audit of the new about:welcome pages.

In this patch, the topsites images on the import page point to the footer at the bottom of the page with aria-labelledby. VoiceOver reads the text in the footer after reading the rest of the page, instead of the aria-labelledby.

VoiceOver also fails to read the "Getting started: step x of y" aria-label on the <nav> element at the bottom of about:welcome.

(This patch has landed, so it should be able to be tested by opening about:welcome on a new profile of Nightly. If the footer isn't there, make sure the value of browser.aboutwelcome.overrideContent in about:config is set to the JSON posted in the attachment.)

Comment 1

[Eitan Isaacson [:eeejay]]

Marking this as S2/P1 since it fits our goal of having good role/label mapping in mac.

Comment 2

[Eitan Isaacson [:eeejay]]

This works for me now. Note, that #topsites-disclaimer seems to not exist there anymore. But this HTML works with VoiceOver as expected - i can hear the name of the region and the label on the nav:

data:text/html,<div role="region" aria-label="this is are region">some stuff</div><nav aria-label="this is a nav element">more nav stuff</nav>

Emily, sorry this took a while. Can you confirm that this issue has been resolved? Thanks!

Comment 3

[Emily McMinn :emcminn]

Hi Eitan, thanks for looking at this! The #topsites-disclaimer has actually been removed in the current incarnation of about:welcome; so it's fine that you're not hearing it! I've verified that the Getting Started label on the nav is now being picked up correctly, so I'd say we're good. :)

Comment 4

[Eitan Isaacson [:eeejay]]

Awesome, thanks! I'll close as Works for Me.