Closed Bug 1655111 Opened 4 years ago Closed 4 years ago

Move symbolstore tests out of `make check`

Categories

(Firefox Build System :: General, task)

task

Tracking

(firefox-esr78 fixed, firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox-esr78 --- fixed
firefox81 --- fixed

People

(Reporter: rstewart, Assigned: rstewart)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → rstewart
Blocks: 1210759

After bug 1614626, the last remaining python-test that runs during builds is the symbolstore Python tests. Having discussed the tests with other build peers, nobody seems to think these tests are valuable or have recently failed or uncovered an issue. In lieu of changing the way the symbolstore tests work we can leave them in-tree unchanged for now and just stop running them in CI entirely.

Depends on: 1614626

In the long run you'd be better served by having someone fix bug 1306678. Of the tests in unit-symbolstore.py, the only thing that is really valuable is the functional test, which checks that the generated symbols work properly and have a few required properties like mapping source files which could otherwise go unnoticed but are incredibly important for crash reports.

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/61efef576d74 Stop running `mach python-test` during `make check` r=froydnj
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Comment on attachment 9166692 [details]
Bug 1655111 - Stop running mach python-test during make check

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to uplift https://bugzilla.mozilla.org/show_bug.cgi?id=1654457, otherwise python-tests running as part of make fail, because they're run with the wrong virtualenv.
  • User impact if declined: None
  • Fix Landed on Version: 81
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a build-only patch
  • String or UUID changes made by this patch:
Attachment #9166692 - Flags: approval-mozilla-esr78?

Comment on attachment 9166692 [details]
Bug 1655111 - Stop running mach python-test during make check

Needed to better support running mach on newer macOS releases. Approved for 78.8esr.

Attachment #9166692 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: