1655111 - Move symbolstore tests out of `make check`

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Ricky Stewart]

Attachment: Bug 1655111 - Stop running `mach python-test` during `make check`

After bug 1614626, the last remaining python-test that runs during builds is the symbolstore Python tests. Having discussed the tests with other build peers, nobody seems to think these tests are valuable or have recently failed or uncovered an issue. In lieu of changing the way the symbolstore tests work we can leave them in-tree unchanged for now and just stop running them in CI entirely.

Comment 2

[(not currently active) Ted Mielczarek]

In the long run you'd be better served by having someone fix bug 1306678. Of the tests in unit-symbolstore.py, the only thing that is really valuable is the functional test, which checks that the generated symbols work properly and have a few required properties like mapping source files which could otherwise go unnoticed but are incredibly important for crash reports.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61efef576d74
Stop running `mach python-test` during `make check` r=froydnj

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/61efef576d74

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Comment on attachment 9166692 [details]
Bug 1655111 - Stop running mach python-test during make check

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to uplift https://bugzilla.mozilla.org/show_bug.cgi?id=1654457, otherwise python-tests running as part of make fail, because they're run with the wrong virtualenv.
• User impact if declined: None
• Fix Landed on Version: 81
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a build-only patch
• String or UUID changes made by this patch:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9166692 [details]
Bug 1655111 - Stop running mach python-test during make check

Needed to better support running mach on newer macOS releases. Approved for 78.8esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/e901b8f5b9df