Closed Bug 1655184 Opened 6 months ago Closed 5 months ago

[wpt-sync] Sync PR 24743 - [LCP] Ignore paints with opacity 0

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox81 fixed)

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24743 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24743
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

[LCP] Ignore paints with opacity 0

This changes the opacity 0 paints that are ignored by the LCP algorithm.
Before, paints that would later be composited were not ignored, which
resulted in an inaccurate metric due to detecting LCP too early. After
this change, even will-change opacity paints are ignored, which could
result in elements not becoming candidates because they are never
repainted. In the special case where documentElement changes its
opacity, we consider the largest content that becomes visible as a valid
LCP candidate.

Bug: 1092473
Change-Id: I2a970a34fdb1db6c7c746060c286077553b816a6

Reviewed-on: https://chromium-review.googlesource.com/2316788
WPT-Export-Revision: a11c995b8b9c6281064c71f601b644967b74ee80

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/largest-contentful-paint/invisible-images-composited-1.html
Images with opacity: 0, visibility: hidden, or display: none are not observable by LargestContentfulPaint.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd658619039a
[wpt PR 24743] - [LCP] Ignore paints with opacity 0, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1ad4ba756ad
[wpt PR 24743] - [LCP] Ignore paints with opacity 0, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b1ad4ba756ad

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.